Re: Use $(SHELL) when running move-if-change

[Ian Lance Taylor <ian@airs.com>]

Ben Elliston <bje@au.ibm.com> writes:

> Ian Lance Taylor <ian@airs.com> writes:
> 
> > I'm checking in this patch to bfd/doc/Makefile.am to use $(SHELL)
> > when running move-if-change.  $(SHELL) should always be used with
> > move-if-change or indeed any shell script.  I suppose this one went
> > unfixed for so long because it is only run when recreating info
> > files, which normally does not need to be done when using a released
> > version.
> 
> While we're discussing move-if-change here is a trivial patch that has
> been sitting in my tree for some time.  I always build with make -s,
> so this bugs me perhaps more than most.  Like mv(1), move-if-change
> should be silent, too.  Okay for mainline?
> 
> 2004-11-01  Ben Elliston  <bje@au.ibm.com>
> 
> 	* move-if-change: Don't produce any output, just like mv(1).

Personally I would just as soon keep the top level files in synch with
gcc as much as possible.  So, how about if it is accepted for gcc,
it's OK for binutils?

If we want to get fancy, we could try this patch:

--- move-if-change.~1~	2004-12-20 21:26:12.422896127 -0500
+++ move-if-change	2004-12-20 21:31:21.019936480 -0500
@@ -22,7 +22,10 @@
 if
 cmp $1 $2 > /dev/null
 then
-echo $2 is unchanged
+case `echo "$MAKEFLAGS" | sed -e 's/\([^ ]*\).*/\1/'` in
+  *s*) ;;
+  *) echo $2 is unchanged ;;
+esac
 rm -f $1
 else
 mv -f $1 $2


Ian