From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-36912-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 14217 invoked by alias); 21 Dec 2004 02:32:40 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 14173 invoked from network); 21 Dec 2004 02:32:36 -0000
Received: from unknown (205.217.158.180)
  by sourceware.org with QMTP; 21 Dec 2004 02:32:36 -0000
Received: (qmail 7356 invoked by uid 10); 21 Dec 2004 02:32:34 -0000
Received: (qmail 2118 invoked by uid 500); 21 Dec 2004 02:32:25 -0000
Mail-Followup-To: binutils@sources.redhat.com,
  bje@au.ibm.com
To: Ben Elliston <bje@au.ibm.com>
Cc: binutils@sources.redhat.com
Subject: Re: Use $(SHELL) when running move-if-change
References: <20041220212226.32268.qmail@gossamer.airs.com>
	<87zn08edhb.fsf@au.ibm.com>
From: Ian Lance Taylor <ian@airs.com>
Date: Tue, 21 Dec 2004 02:32:00 -0000
In-Reply-To: <87zn08edhb.fsf@au.ibm.com>
Message-ID: <m3zn088jpi.fsf@gossamer.airs.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-12/txt/msg00253.txt.bz2

Ben Elliston <bje@au.ibm.com> writes:

> Ian Lance Taylor <ian@airs.com> writes:
> 
> > I'm checking in this patch to bfd/doc/Makefile.am to use $(SHELL)
> > when running move-if-change.  $(SHELL) should always be used with
> > move-if-change or indeed any shell script.  I suppose this one went
> > unfixed for so long because it is only run when recreating info
> > files, which normally does not need to be done when using a released
> > version.
> 
> While we're discussing move-if-change here is a trivial patch that has
> been sitting in my tree for some time.  I always build with make -s,
> so this bugs me perhaps more than most.  Like mv(1), move-if-change
> should be silent, too.  Okay for mainline?
> 
> 2004-11-01  Ben Elliston  <bje@au.ibm.com>
> 
> 	* move-if-change: Don't produce any output, just like mv(1).

Personally I would just as soon keep the top level files in synch with
gcc as much as possible.  So, how about if it is accepted for gcc,
it's OK for binutils?

If we want to get fancy, we could try this patch:

--- move-if-change.~1~	2004-12-20 21:26:12.422896127 -0500
+++ move-if-change	2004-12-20 21:31:21.019936480 -0500
@@ -22,7 +22,10 @@
 if
 cmp $1 $2 > /dev/null
 then
-echo $2 is unchanged
+case `echo "$MAKEFLAGS" | sed -e 's/\([^ ]*\).*/\1/'` in
+  *s*) ;;
+  *) echo $2 is unchanged ;;
+esac
 rm -f $1
 else
 mv -f $1 $2


Ian