From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-70577-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 1444 invoked by alias); 9 Mar 2011 15:35:08 -0000
Received: (qmail 1086 invoked by uid 22791); 9 Mar 2011 15:35:06 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 15:35:01 +0000
Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101])	by smtp-out.google.com with ESMTP id p29FYw9c031257	for <binutils@sourceware.org>; Wed, 9 Mar 2011 07:34:58 -0800
Received: from yxn22 (yxn22.prod.google.com [10.190.4.86])	by wpaz37.hot.corp.google.com with ESMTP id p29FYuwN020496	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <binutils@sourceware.org>; Wed, 9 Mar 2011 07:34:57 -0800
Received: by yxn22 with SMTP id 22so279970yxn.6        for <binutils@sourceware.org>; Wed, 09 Mar 2011 07:34:56 -0800 (PST)
Received: by 10.236.190.195 with SMTP id e43mr35263yhn.217.1299684896251;        Wed, 09 Mar 2011 07:34:56 -0800 (PST)
Received: from coign.google.com ([67.218.107.6])        by mx.google.com with ESMTPS id g63sm1374814yhd.15.2011.03.09.07.34.54        (version=TLSv1/SSLv3 cipher=OTHER);        Wed, 09 Mar 2011 07:34:55 -0800 (PST)
From: Ian Lance Taylor <iant@google.com>
To: Andreas Schwab <schwab@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: gold patch committed: Check IOV_MAX
References: <mcrfwqxqcqv.fsf@google.com> <m3mxl4y6rt.fsf@redhat.com>
Date: Wed, 09 Mar 2011 15:35:00 -0000
In-Reply-To: <m3mxl4y6rt.fsf@redhat.com> (Andreas Schwab's message of "Wed, 09	Mar 2011 10:36:54 +0100")
Message-ID: <mcr4o7cpasl.fsf@google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00183.txt.bz2

Andreas Schwab <schwab@redhat.com> writes:

> Ian Lance Taylor <iant@google.com> writes:
>
>> @@ -605,11 +606,22 @@ File_read::do_readv(off_t base, const Re
>>  	       got, want, static_cast<long long>(base + first_offset));
>>  }
>>  
>> +// Portable IOV_MAX.
>> +
>> +#if !defined(HAVE_READV)
>> +#define GOLD_IOV_MAX 1
>> +#elif defined(IOV_MAX)
>> +#define GOLD_IOV_MAX IOV_MAX
>> +#else
>> +#define GOLD_IOV_MAX (File_read::max_readv_entries * 2)
>> +#endif
>> +
>>  // Read several pieces of data from the file.
>>  
>>  void
>>  File_read::read_multiple(off_t base, const Read_multiple& rm)
>>  {
>> +  static size_t iov_max = GOLD_IOV_MAX;
>
> const?

I've written the code this way because IOV_MAX need not be a constant.
It may be a call to sysconf.

Ian