From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18308 invoked by alias); 19 Oct 2010 19:29:30 -0000 Received: (qmail 18294 invoked by uid 22791); 19 Oct 2010 19:29:29 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Oct 2010 19:29:24 +0000 Received: from kpbe20.cbf.corp.google.com (kpbe20.cbf.corp.google.com [172.25.105.84]) by smtp-out.google.com with ESMTP id o9JJTLM6019997 for ; Tue, 19 Oct 2010 12:29:21 -0700 Received: from pvg2 (pvg2.prod.google.com [10.241.210.130]) by kpbe20.cbf.corp.google.com with ESMTP id o9JJTJSp014704 for ; Tue, 19 Oct 2010 12:29:20 -0700 Received: by pvg2 with SMTP id 2so757518pvg.26 for ; Tue, 19 Oct 2010 12:29:19 -0700 (PDT) Received: by 10.142.131.17 with SMTP id e17mr3627112wfd.320.1287516559636; Tue, 19 Oct 2010 12:29:19 -0700 (PDT) Received: from coign.google.com (dhcp-172-22-123-203.mtv.corp.google.com [172.22.123.203]) by mx.google.com with ESMTPS id e14sm19242686wfg.20.2010.10.19.12.29.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 19 Oct 2010 12:29:18 -0700 (PDT) From: Ian Lance Taylor To: =?utf-8?B?RG91ZyBLd2FuICjpl5zmjK/lvrcp?= Cc: binutils Subject: Re: [GOLD][PATCH] Set SHF_LINK_ORDER flags of ARM EXIDX sections. References: Date: Tue, 19 Oct 2010 19:29:00 -0000 In-Reply-To: ("Doug Kwan =?utf-8?B?KOmXnOaMr+W+tykiJ3M=?= message of "Wed, 20 Oct 2010 02:53:52 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00313.txt.bz2 "Doug Kwan (=E9=97=9C=E6=8C=AF=E5=BE=B7)" writes: > 2010-10-19 Doug Kwan > > * arm.cc (Target_arm::do_finalize_sections): Force SHF_LINK_ORDER > flag in section headers of EXIDX sections in a relocatable link. > * output.cc (Output_section::Output_section): Initialize member > force_link_order_. > * output.h (Output_section::force_link_order): New method. > (Output_section::set_force_link_order): Ditto. > (Output_section::force_link_order_): New data member. > + // Whether we always set SHF_LINK_ORDER in section header. > + bool > + force_link_order() const > + { return this->force_link_order_; } > + > + // Force setting SHF_LINK_ORDER in output section header.=20 > + void > + set_force_link_order(bool value) > + { this->force_link_order_ =3D value; } > + > protected: > // Return the output section--i.e., the object itself. > Output_section* > @@ -3765,6 +3775,8 @@ class Output_section : public Output_dat > Checkpoint_output_section* checkpoint_; > // Fast lookup maps for merged and relaxed input sections. > Output_section_lookup_maps* lookup_maps_; > + // Force SHF_LINK_ORDER in section header. > + bool force_link_order_; > }; Name the field simply is_link_order_, make it a 1 bit bitfield, and put it just after is_noload_. Name the accessors is_link_order and set_is_link_order. This is OK with those changes. Thanks. Ian