public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Aleksandar Simeonov <Aleksandar.Simeonov@RT-RK.com>
Cc: "Fuhler\, Rich" <rich@mips.com>,
	 mips-compiler@rt-rk.com,  binutils <binutils@sourceware.org>
Subject: Re: Initial MIPS patch for GOLD - version 3
Date: Sat, 28 Jan 2012 01:55:00 -0000	[thread overview]
Message-ID: <mcraa58mw0o.fsf@dhcp-172-18-216-180.mtv.corp.google.com> (raw)
In-Reply-To: <4F1ED098.2060508@RT-RK.com> (Aleksandar Simeonov's message of	"Tue, 24 Jan 2012 16:39:04 +0100")

Aleksandar Simeonov <Aleksandar.Simeonov@RT-RK.com> writes:

> * reloc.cc (Sized_relobj_file<size, big_endian>::write_sections): Special
> handling of MIPS .reginfo section.
> - .reginfo section is generated by linker and needs special handling.

I haven't thought about everything, but I can see that this patch is not
going to work as is.  It will fail when linking a non-MIPS object which
happens to have a section type == SHT_MIPS_REGINFO.  We can't use
processor-specific values like SHT_MIPS_REGINFO outside of the CPU.cc
file.

> * layout.cc (Layout::segment_precedes): Fixed order of MIPS specific
> segments.
> - MIPS needs to have PT_MIPS_REGINFO segment before any loadable segment.

This is similarly troubling, though probably less serious.

> - MIPS needs to have PT_NULL segment to be last in list of segments.

Why would we ever have a PT_NULL segment?

Ian

  parent reply	other threads:[~2012-01-28  1:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24 15:39 Aleksandar Simeonov
2012-01-28  1:06 ` Ian Lance Taylor
2012-01-28  1:48 ` Ian Lance Taylor
2012-01-28  1:55 ` Ian Lance Taylor [this message]
2012-01-28  2:11   ` John Reiser
2012-01-29 12:13     ` Richard Sandiford
2012-02-03 15:40 Simeonov, Aleksandar (c)
2012-03-07 14:26 ` Simeonov, Aleksandar (c)
2012-03-07 14:54   ` Ian Lance Taylor
2012-03-07 19:46     ` Fuhler, Rich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcraa58mw0o.fsf@dhcp-172-18-216-180.mtv.corp.google.com \
    --to=iant@google.com \
    --cc=Aleksandar.Simeonov@RT-RK.com \
    --cc=binutils@sourceware.org \
    --cc=mips-compiler@rt-rk.com \
    --cc=rich@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).