public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [gold patch] Incremental 15/18: Add --incremental-base option.
Date: Tue, 24 May 2011 23:08:00 -0000	[thread overview]
Message-ID: <mcrd3j7g0iv.fsf@coign.corp.google.com> (raw)
In-Reply-To: <BANLkTinv8Dr2rcPGXbv-1hXLwV2khGdPnA@mail.gmail.com> (Cary	Coutant's message of "Tue, 24 May 2011 15:54:09 -0700")

Cary Coutant <ccoutant@google.com> writes:

> 2011-05-24 Cary Coutant  <ccoutant@google.com>
>
> 	* gold.cc (queue_initial_tasks): Pass incremental base filename
> 	to Output_file::open_base_file; don't print error message.
> 	* incremental-dump.cc (main): Adjust call to
> 	Output_file::open_for_modification.
> 	* incremental-dump.cc (main): Likewise.
> 	* incremental.cc (Incremental_inputs::report_command_line):
> 	Ignore --incremental-base option when comparing command lines.
> 	Ignore parameter when given as separate argument.
> 	* options.h (class General_options): Add --incremental-base.
> 	* output.cc (Output_file::Output_file):
> 	(Output_file::open_base_file): Add base_name and writable parameters;
> 	read base file into new file; print error message here.
> 	(Output_file::map_no_anonymous): Add writable parameter; adjust all
> 	callers.
> 	* output.h (Output_file::open_for_modification): Rename to...
> 	(Output_file::open_base_file): ...this; add base_name and
> 	writable parameters; adjust all callers.
> 	(Output_file::map_no_anonymous): Add writable parameter; adjust all
> 	callers.
> 	* testsuite/Makefile.am (incremental_test_4): Test
> 	--incremental-base.
> 	* testsuite/Makefile.in: Regenerate.

This is OK.

Thanks.

Ian

  reply	other threads:[~2011-05-24 23:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 23:30 Cary Coutant
2011-04-25 20:33 ` Cary Coutant
2011-05-24 14:59   ` Ian Lance Taylor
2011-05-24 22:20     ` Cary Coutant
2011-05-24 22:54       ` Cary Coutant
2011-05-24 23:08         ` Ian Lance Taylor [this message]
2011-05-24 23:33           ` Cary Coutant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcrd3j7g0iv.fsf@coign.corp.google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=ccoutant@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).