From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17197 invoked by alias); 24 May 2011 23:08:29 -0000 Received: (qmail 17189 invoked by uid 22791); 24 May 2011 23:08:28 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 23:08:15 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id p4ON8DPI022598 for ; Tue, 24 May 2011 16:08:13 -0700 Received: from pzk30 (pzk30.prod.google.com [10.243.19.158]) by kpbe15.cbf.corp.google.com with ESMTP id p4ON8B6t026377 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 24 May 2011 16:08:11 -0700 Received: by pzk30 with SMTP id 30so3743821pzk.32 for ; Tue, 24 May 2011 16:08:11 -0700 (PDT) Received: by 10.68.33.40 with SMTP id o8mr3106999pbi.520.1306278491154; Tue, 24 May 2011 16:08:11 -0700 (PDT) Received: from coign.google.com (dhcp-172-18-113-207.mtv.corp.google.com [172.18.113.207]) by mx.google.com with ESMTPS id x6sm5278241pbx.86.2011.05.24.16.08.10 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 May 2011 16:08:10 -0700 (PDT) From: Ian Lance Taylor To: Cary Coutant Cc: Binutils Subject: Re: [gold patch] Incremental 15/18: Add --incremental-base option. References: Date: Tue, 24 May 2011 23:08:00 -0000 In-Reply-To: (Cary Coutant's message of "Tue, 24 May 2011 15:54:09 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00343.txt.bz2 Cary Coutant writes: > 2011-05-24 Cary Coutant > > * gold.cc (queue_initial_tasks): Pass incremental base filename > to Output_file::open_base_file; don't print error message. > * incremental-dump.cc (main): Adjust call to > Output_file::open_for_modification. > * incremental-dump.cc (main): Likewise. > * incremental.cc (Incremental_inputs::report_command_line): > Ignore --incremental-base option when comparing command lines. > Ignore parameter when given as separate argument. > * options.h (class General_options): Add --incremental-base. > * output.cc (Output_file::Output_file): > (Output_file::open_base_file): Add base_name and writable parameters; > read base file into new file; print error message here. > (Output_file::map_no_anonymous): Add writable parameter; adjust all > callers. > * output.h (Output_file::open_for_modification): Rename to... > (Output_file::open_base_file): ...this; add base_name and > writable parameters; adjust all callers. > (Output_file::map_no_anonymous): Add writable parameter; adjust all > callers. > * testsuite/Makefile.am (incremental_test_4): Test > --incremental-base. > * testsuite/Makefile.in: Regenerate. This is OK. Thanks. Ian