public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Richard Guenther <rguenther@suse.de>
Cc: "Sriraman Tallam" <tmsriram@google.com>,
	binutils <binutils@sourceware.org>,
	"Doug Kwan (關振德)" <dougkwan@google.com>
Subject: Re: Dangling pointer in ICF from c_str method.
Date: Thu, 03 Feb 2011 20:42:00 -0000	[thread overview]
Message-ID: <mcrd3n897f7.fsf@google.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1102031040380.17230@zhemvz.fhfr.qr> (Richard	Guenther's message of "Thu, 3 Feb 2011 10:41:13 +0100 (CET)")

Richard Guenther <rguenther@suse.de> writes:

> On Wed, 2 Feb 2011, Sriraman Tallam wrote:
>
>> Hi,
>> 
>>    Doug Kwan found a bug in ICF caused by a dangling pointer from
>> using c_str on a temporary string object. I have attached a patch to
>> fix it. I suspect this as the cause of bug  reported in :
>> http://sourceware.org/bugzilla/show_bug.cgi?id=12388. Richard, could
>> you please see if this patch fixes the bug as I am unable to reproduce
>> it.
>
> It doesn't apply to the 2.21 release for me.  I'll pick it up when
> 2.21.1 is released.

I applied Sri's patch to binutils 2.21 branch.

Ian

      reply	other threads:[~2011-02-03 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 21:20 Sriraman Tallam
2011-02-02 21:48 ` Ian Lance Taylor
2011-02-02 21:57   ` Sriraman Tallam
2011-02-03  9:41 ` Richard Guenther
2011-02-03 20:42   ` Ian Lance Taylor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcrd3n897f7.fsf@google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=dougkwan@google.com \
    --cc=rguenther@suse.de \
    --cc=tmsriram@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).