From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22675 invoked by alias); 16 Feb 2012 02:15:58 -0000 Received: (qmail 22645 invoked by uid 22791); 16 Feb 2012 02:15:57 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-pz0-f41.google.com (HELO mail-pz0-f41.google.com) (209.85.210.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 02:15:16 +0000 Received: by dadv6 with SMTP id v6so1601553dad.0 for ; Wed, 15 Feb 2012 18:15:16 -0800 (PST) Received: by 10.68.216.4 with SMTP id om4mr8884355pbc.19.1329358514992; Wed, 15 Feb 2012 18:15:14 -0800 (PST) Received: by 10.68.216.4 with SMTP id om4mr8883767pbc.19.1329358509724; Wed, 15 Feb 2012 18:15:09 -0800 (PST) Received: from coign.google.com ([67.218.103.10]) by mx.google.com with ESMTPS id r10sm12532909pbs.12.2012.02.15.18.15.06 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Feb 2012 18:15:08 -0800 (PST) From: Ian Lance Taylor To: John Marino Cc: binutils@sourceware.org Subject: Re: suggestion for gold's testsuite makefile (initpri2 LDFLAGS) References: <4F2FC254.4080800@marino.st> <4F3B7A92.9010100@marino.st> Date: Thu, 16 Feb 2012 02:15:00 -0000 In-Reply-To: <4F3B7A92.9010100@marino.st> (John Marino's message of "Wed, 15 Feb 2012 10:27:46 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQnKBK+L9tCTBH1Va1LUIyjEg43WZWZnIGGFtcaNxAYVxntu+GjWfCaRzrEtnbhcqwIEJpTXreNEc2nulLmX3tREcGv9KhRn8m19VSyiAncBYtZ+w/cl+lD2aGaI3iMwpfM96v6xcc/iwg4M2eMZjJFvDTeAt1LzL5QQeUhiWc+V6DedhqE= X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00130.txt.bz2 John Marino writes: > On 2/6/2012 13:06, John Marino wrote: >> The initpri2 test can only pass if the --ctors-in-init-array option is >> enabled. With a default build, Gold enables this option by default. >> Still, the testsuite should not assume the option is enabled, it should >> explicitly set it. >> >> Suggestion to change line 2280 of Makefile.in FROM: >> @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ >> TO >> @GCC_TRUE@@NATIVE_LINKER_TRUE@initpri2_LDFLAGS = -Bgcctestdir/ -Wl,--ctors-in-init-array >> >> >> As background, the BSDs need to build Gold with a modified options.h >> file to set --no-ctors-in-init-array as the default. I'm in the >> process of getting DragonFly BSD to support DT_INIT_ARRAY and friends >> and this test was failing even though the crt1.o had been properly >> modified to support it. Making this change either has no effect or >> it means the difference between a pass or fail on a capable system >> with a non-standard ctors-in-init-array default. >> >> John > > > I don't think anybody responded to this post from last week, but I > don't want it to fall between the cracks. Is it a good idea to modify > the gold testsuite makefile with this change? Yes, it's fine. The obvious patch is preapproved if anybody cares to commit it. Sorry, I've been completely swamped. Ian