From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22682 invoked by alias); 25 Apr 2011 19:54:36 -0000 Received: (qmail 22663 invoked by uid 22791); 25 Apr 2011 19:54:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Apr 2011 19:54:20 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id p3PJsIPK029305 for ; Mon, 25 Apr 2011 12:54:18 -0700 Received: from pxi15 (pxi15.prod.google.com [10.243.27.15]) by kpbe11.cbf.corp.google.com with ESMTP id p3PJquSm025209 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 25 Apr 2011 12:54:16 -0700 Received: by pxi15 with SMTP id 15so2002633pxi.5 for ; Mon, 25 Apr 2011 12:54:16 -0700 (PDT) Received: by 10.68.57.242 with SMTP id l18mr3301073pbq.30.1303761256416; Mon, 25 Apr 2011 12:54:16 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id a1sm4081746pbo.91.2011.04.25.12.54.14 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2011 12:54:15 -0700 (PDT) From: Ian Lance Taylor To: Cary Coutant Cc: Binutils Subject: Re: [gold patch] Incremental 10/18: Add support for local symbols References: Date: Mon, 25 Apr 2011 19:54:00 -0000 In-Reply-To: (Cary Coutant's message of "Wed, 30 Mar 2011 16:43:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00354.txt.bz2 Cary Coutant writes: > 2011-03-30 Cary Coutant > > * gold/incremental-dump.cc (dump_incremental_inputs): Print local > symbol info for each input file. > * gold/incremental.cc > (Output_section_incremental_inputs::set_final_data_size): Add local > symbol info to input file entries in incremental info. > (Output_section_incremental_inputs::write_info_blocks): Likewise. > (Sized_incr_relobj::Sized_incr_relobj): Initialize new data members. > (Sized_incr_relobj::do_add_symbols): Cosmetic change. > (Sized_incr_relobj::do_count_local_symbols): Replace stub with > implementation. > (Sized_incr_relobj::do_finalize_local_symbols): Likewise. > (Sized_incr_relobj::do_relocate): Write the local symbols. > (Sized_incr_dynobj::do_add_symbols): Cosmetic change. > * gold/incremental.h (Incremental_inputs_reader::get_symbol_offset): > Adjust size of input file header. > (Incremental_inputs_reader::get_local_symbol_offset): New function. > (Incremental_inputs_reader::get_local_symbol_count): New function. > (Incremental_inputs_reader::get_input_section): Adjust size of input > file header. > (Incremental_inputs_reader::get_global_symbol_reader): Likewise. > (Sized_incr_relobj::This): New typedef. > (Sized_incr_relobj::sym_size): New const data member. > (Sized_incr_relobj::Local_symbol): New struct. > (Sized_incr_relobj::do_output_local_symbol_count): New function. > (Sized_incr_relobj::do_local_symbol_offset): New function. > (Sized_incr_relobj::local_symbol_count_): New data member. > (Sized_incr_relobj::output_local_dynsym_count_): New data member. > (Sized_incr_relobj::local_symbol_index_): New data member. > (Sized_incr_relobj::local_symbol_offset_): New data member. > (Sized_incr_relobj::local_dynsym_offset_): New data member. > (Sized_incr_relobj::local_symbols_): New data member. > * gold/object.h (Relobj::output_local_symbol_count): New function. > (Relobj::local_symbol_offset): New function. > (Relobj::do_output_local_symbol_count): New function. > (Relobj::do_local_symbol_offset): New function. > (Sized_relobj::do_output_local_symbol_count): New function. > (Sized_relobj::do_local_symbol_offset): New function. This is OK. Thanks. Ian