public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* gold patch committed: Report value of unsupported binding
@ 2010-10-11 20:06 Ian Lance Taylor
  0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2010-10-11 20:06 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

When gold reports an error about an unsupported symbol binding, it
neglects to report the value.  This has led to a series of guesses about
the recently added STB_GNU_UNIQUE binding.  This patch changes the error
message so that the value of the binding is supported so that we don't
need to make those guesses next time around.  Committed to mainline.

Ian


2010-10-11  Ian Lance Taylor  <iant@google.com>

	* resolve.cc (symbol_to_bits): Report the value of the unsupported
	binding.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: binding --]
[-- Type: text/x-diff, Size: 618 bytes --]

Index: resolve.cc
===================================================================
RCS file: /cvs/src/src/gold/resolve.cc,v
retrieving revision 1.57
diff -p -u -r1.57 resolve.cc
--- resolve.cc	28 Aug 2010 08:05:04 -0000	1.57
+++ resolve.cc	11 Oct 2010 20:01:34 -0000
@@ -195,7 +195,7 @@ symbol_to_bits(elfcpp::STB binding, bool
     default:
       // Any target which wants to handle STB_LOOS, etc., needs to
       // define a resolve method.
-      gold_error(_("unsupported symbol binding"));
+      gold_error(_("unsupported symbol binding %d"), static_cast<int>(binding));
       bits = global_flag;
     }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-10-11 20:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-11 20:06 gold patch committed: Report value of unsupported binding Ian Lance Taylor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).