From: Ian Lance Taylor <iant@google.com>
To: binutils@sourceware.org
Subject: gold patch committed: Fix i386 testsuite failure
Date: Sat, 09 Jul 2011 06:00:00 -0000 [thread overview]
Message-ID: <mcrr560ujgo.fsf@coign.corp.google.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
This patch fixes a failure in gold built for 32-bit x86. The test only
works if Ordering::operator() is a different size in the compiled
odr_violation1.cc and odr_violation2.cc. The existing code was too
similar, and the size wound up being the same in 32-bit mode. This
patch makes the size different. The actual contents of the function are
irrelevant for this test. Committed to mainline.
Ian
2011-07-08 Ian Lance Taylor <iant@google.com>
* testsuite/odr_violation2.cc (Ordering::operator()): Make
expression more complex.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 604 bytes --]
Index: testsuite/odr_violation2.cc
===================================================================
RCS file: /cvs/src/src/gold/testsuite/odr_violation2.cc,v
retrieving revision 1.4
diff -u -r1.4 odr_violation2.cc
--- testsuite/odr_violation2.cc 11 Mar 2011 21:42:12 -0000 1.4
+++ testsuite/odr_violation2.cc 9 Jul 2011 05:09:21 -0000
@@ -12,7 +12,7 @@
bool Ordering::operator()(int a, int b) {
// Optimization makes this operator() a different size than the one
// in odr_violation1.cc.
- return a + 1 > b + 1;
+ return a + 12345 > b / 67;
}
void SortDescending(int array[], int size) {
reply other threads:[~2011-07-09 5:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mcrr560ujgo.fsf@coign.corp.google.com \
--to=iant@google.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).