public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* gold patch committed: Fix i386 testsuite failure
@ 2011-07-09  6:00 Ian Lance Taylor
  0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2011-07-09  6:00 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

This patch fixes a failure in gold built for 32-bit x86.  The test only
works if Ordering::operator() is a different size in the compiled
odr_violation1.cc and odr_violation2.cc.  The existing code was too
similar, and the size wound up being the same in 32-bit mode.  This
patch makes the size different.  The actual contents of the function are
irrelevant for this test.  Committed to mainline.

Ian


2011-07-08  Ian Lance Taylor  <iant@google.com>

	* testsuite/odr_violation2.cc (Ordering::operator()): Make
	expression more complex.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 604 bytes --]

Index: testsuite/odr_violation2.cc
===================================================================
RCS file: /cvs/src/src/gold/testsuite/odr_violation2.cc,v
retrieving revision 1.4
diff -u -r1.4 odr_violation2.cc
--- testsuite/odr_violation2.cc	11 Mar 2011 21:42:12 -0000	1.4
+++ testsuite/odr_violation2.cc	9 Jul 2011 05:09:21 -0000
@@ -12,7 +12,7 @@
 bool Ordering::operator()(int a, int b) {
   // Optimization makes this operator() a different size than the one
   // in odr_violation1.cc.
-  return a + 1 > b + 1;
+  return a + 12345 > b / 67;
 }
 
 void SortDescending(int array[], int size) {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-09  5:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-09  6:00 gold patch committed: Fix i386 testsuite failure Ian Lance Taylor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).