* [gold patch] Change incremental_test_2 to turn off -g
@ 2011-07-07 0:06 Cary Coutant
2011-07-07 14:12 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Cary Coutant @ 2011-07-07 0:06 UTC (permalink / raw)
To: Ian Lance Taylor, Binutils
This patch changes incremental_test_2 to compile its test .o files
with -g turned off. With debug info, the incremental update would
sometimes still run out of patch space for debug info, even with the
--incremental-patch parameter set to 100%.
OK?
-cary
* testsuite/Makefile.am (two_file_test_1_v1_ndebug.o): New target.
(two_file_test_1_ndebug.o): Likewise.
(two_file_test_1b_ndebug.o): Likewise.
(two_file_test_2_ndebug.o): Likewise.
(two_file_test_main_ndebug.o): Likewise.
(incremental_test_2): Link with no-debug versions.
diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 67a63f0..a01218a 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -1898,15 +1898,26 @@ memory_test.stdout: memory_test
if DEFAULT_TARGET_X86_64
+two_file_test_1_v1_ndebug.o: two_file_test_1_v1.cc
+ $(CXXCOMPILE) -O0 -g0 -c -o $@ $<
+two_file_test_1_ndebug.o: two_file_test_1.cc
+ $(CXXCOMPILE) -O0 -g0 -c -o $@ $<
+two_file_test_1b_ndebug.o: two_file_test_1b.cc
+ $(CXXCOMPILE) -O0 -g0 -c -o $@ $<
+two_file_test_2_ndebug.o: two_file_test_2.cc
+ $(CXXCOMPILE) -O0 -g0 -c -o $@ $<
+two_file_test_main_ndebug.o: two_file_test_main.cc
+ $(CXXCOMPILE) -O0 -g0 -c -o $@ $<
+
check_PROGRAMS += incremental_test_2
MOSTLYCLEANFILES += two_file_test_tmp_2.o
-incremental_test_2: two_file_test_1_v1.o two_file_test_1.o two_file_test_1b.o \
- two_file_test_2.o two_file_test_main.o gcctestdir/ld
- cp -f two_file_test_1_v1.o two_file_test_tmp_2.o
- $(CXXLINK) -Wl,--incremental-full,--incremental-patch=100
-Bgcctestdir/ two_file_test_tmp_2.o two_file_test_1b.o
two_file_test_2.o two_file_test_main.o
+incremental_test_2: two_file_test_1_v1_ndebug.o
two_file_test_1_ndebug.o two_file_test_1b_ndebug.o \
+ two_file_test_2_ndebug.o two_file_test_main_ndebug.o gcctestdir/ld
+ cp -f two_file_test_1_v1_ndebug.o two_file_test_tmp_2.o
+ $(CXXLINK) -Wl,--incremental-full,--incremental-patch=100
-Bgcctestdir/ two_file_test_tmp_2.o two_file_test_1b_ndebug.o
two_file_test_2_ndebug.o two_file_test_main_ndebug.o
@sleep 1
- cp -f two_file_test_1.o two_file_test_tmp_2.o
- $(CXXLINK) -Wl,--incremental-update -Bgcctestdir/
two_file_test_tmp_2.o two_file_test_1b.o two_file_test_2.o
two_file_test_main.o
+ cp -f two_file_test_1_ndebug.o two_file_test_tmp_2.o
+ $(CXXLINK) -Wl,--incremental-update -Bgcctestdir/
two_file_test_tmp_2.o two_file_test_1b_ndebug.o
two_file_test_2_ndebug.o two_file_test_main_ndebug.o
check_PROGRAMS += incremental_test_3
MOSTLYCLEANFILES += two_file_test_tmp_3.o
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [gold patch] Change incremental_test_2 to turn off -g
2011-07-07 0:06 [gold patch] Change incremental_test_2 to turn off -g Cary Coutant
@ 2011-07-07 14:12 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2011-07-07 14:12 UTC (permalink / raw)
To: Cary Coutant; +Cc: Binutils
Cary Coutant <ccoutant@google.com> writes:
> * testsuite/Makefile.am (two_file_test_1_v1_ndebug.o): New target.
> (two_file_test_1_ndebug.o): Likewise.
> (two_file_test_1b_ndebug.o): Likewise.
> (two_file_test_2_ndebug.o): Likewise.
> (two_file_test_main_ndebug.o): Likewise.
> (incremental_test_2): Link with no-debug versions.
This is OK.
Thanks.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-07 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-07 0:06 [gold patch] Change incremental_test_2 to turn off -g Cary Coutant
2011-07-07 14:12 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).