public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: vkutuzov@accesssoftek.com, binutils <binutils@sourceware.org>
Subject: Re: [GOLD][PATCH PROPOSAL] prevent discarding of needed local symbols for the relocatable objects
Date: Tue, 10 May 2011 23:56:00 -0000	[thread overview]
Message-ID: <mcrvcxiglh4.fsf@coign.corp.google.com> (raw)
In-Reply-To: <BANLkTi=bPWCtfFvrgeRtbu3moYvY3mxE6Q@mail.gmail.com> (Cary	Coutant's message of "Tue, 10 May 2011 15:29:55 -0700")

Cary Coutant <ccoutant@google.com> writes:

> This patch fixes the problem. Is this OK, or were you thinking that
> do_finalize_local_symbols() shouldn't even assign the symbol index
> when -s is set?

I was thinking the latter.  I see that do_count_local_symbols checks
discard_locals.  It sounds like it should also test strip_all.  A patch
for that is preapproved if it works.

Thanks.

Ian

  reply	other threads:[~2011-05-10 23:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10 23:03 {GOLD][PATCH " Viktor Kutuzov
2010-02-11  2:14 ` Ian Lance Taylor
2010-02-25  0:02   ` [GOLD][PATCH " Viktor Kutuzov
2010-03-03 19:34     ` Ian Lance Taylor
2011-05-10 22:30       ` Cary Coutant
2011-05-10 23:56         ` Ian Lance Taylor [this message]
2011-05-11  0:30           ` Cary Coutant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcrvcxiglh4.fsf@coign.corp.google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=ccoutant@google.com \
    --cc=vkutuzov@accesssoftek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).