From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-71588-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 4046 invoked by alias); 10 May 2011 23:56:20 -0000
Received: (qmail 4037 invoked by uid 22791); 10 May 2011 23:56:19 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 May 2011 23:56:05 +0000
Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101])	by smtp-out.google.com with ESMTP id p4ANu5cO009834	for <binutils@sourceware.org>; Tue, 10 May 2011 16:56:05 -0700
Received: from pvg3 (pvg3.prod.google.com [10.241.210.131])	by wpaz37.hot.corp.google.com with ESMTP id p4ANtvgJ032213	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT)	for <binutils@sourceware.org>; Tue, 10 May 2011 16:56:04 -0700
Received: by pvg3 with SMTP id 3so4101347pvg.18        for <binutils@sourceware.org>; Tue, 10 May 2011 16:55:52 -0700 (PDT)
Received: by 10.68.36.10 with SMTP id m10mr3033887pbj.224.1305071752451;        Tue, 10 May 2011 16:55:52 -0700 (PDT)
Received: from coign.google.com ([66.109.105.72])        by mx.google.com with ESMTPS id i7sm5120272pbs.20.2011.05.10.16.55.49        (version=TLSv1/SSLv3 cipher=OTHER);        Tue, 10 May 2011 16:55:51 -0700 (PDT)
From: Ian Lance Taylor <iant@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: vkutuzov@accesssoftek.com, binutils <binutils@sourceware.org>
Subject: Re: [GOLD][PATCH PROPOSAL] prevent discarding of needed local symbols for the relocatable objects
References: <1265843004.2150.342.camel@dp690-dev5v4>	<mcraavgcydc.fsf@dhcp-172-17-9-151.mtv.corp.google.com>	<1267053412.6817.190.camel@dp690-dev5v4>	<mcrlje9jj32.fsf@dhcp-172-17-9-151.mtv.corp.google.com>	<BANLkTi=bPWCtfFvrgeRtbu3moYvY3mxE6Q@mail.gmail.com>
Date: Tue, 10 May 2011 23:56:00 -0000
In-Reply-To: <BANLkTi=bPWCtfFvrgeRtbu3moYvY3mxE6Q@mail.gmail.com> (Cary	Coutant's message of "Tue, 10 May 2011 15:29:55 -0700")
Message-ID: <mcrvcxiglh4.fsf@coign.corp.google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00127.txt.bz2

Cary Coutant <ccoutant@google.com> writes:

> This patch fixes the problem. Is this OK, or were you thinking that
> do_finalize_local_symbols() shouldn't even assign the symbol index
> when -s is set?

I was thinking the latter.  I see that do_count_local_symbols checks
discard_locals.  It sounds like it should also test strip_all.  A patch
for that is preapproved if it works.

Thanks.

Ian