public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [gold patch] Add inlined fast path for LEB128 routines
Date: Wed, 25 Jan 2012 05:40:00 -0000	[thread overview]
Message-ID: <mcry5swuypb.fsf@dhcp-172-18-216-180.mtv.corp.google.com> (raw)
In-Reply-To: <CAHACq4phYnC51NfOymtoPzmBkUcEug9_-jW2X_K_fnWqkXyM0A@mail.gmail.com>	(Cary Coutant's message of "Tue, 24 Jan 2012 17:24:46 -0800")

Cary Coutant <ccoutant@google.com> writes:

> 2012-01-24  Cary Coutant  <ccoutant@google.com>
>
> 	* int_encoding.cc (read_unsigned_LEB_128): Replaced with inline
> 	definition and ...
> 	(read_unsigned_LEB_128_x): ... this new function.
> 	(read_signed_LEB_128): Replaced with inline definition and ...
> 	(read_signed_LEB_128_x): ... this new function.
> 	* int_encoding.h  (read_unsigned_LEB_128_x): New function.
> 	(read_unsigned_LEB_128): Add inline definition.
> 	(read_signed_LEB_128_x): New function.
> 	(read_signed_LEB_128): Add inline definition.
> 	* testsuite/Makefile.am (leb128_unittest): New unit test.
> 	* testsuite/Makefile.in: Regenerate.
> 	* testsuite/leb128_unittest.cc: New unit test.

> +  if (byte & 0x80)
> +    return read_unsigned_LEB_128_x(buffer, plen, byte);

Write ((byte & 0x80) != 0)

> +  if (byte & 0x80)
> +    return read_signed_LEB_128_x(buffer, plen, byte);

Here too.

This is OK with those changes.

Thanks.

Ian

  reply	other threads:[~2012-01-25  5:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25  1:25 Cary Coutant
2012-01-25  5:40 ` Ian Lance Taylor [this message]
2012-01-25  7:37   ` Cary Coutant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcry5swuypb.fsf@dhcp-172-18-216-180.mtv.corp.google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=ccoutant@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).