From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-74175-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 9619 invoked by alias); 25 Jan 2012 05:40:49 -0000
Received: (qmail 9339 invoked by uid 22791); 25 Jan 2012 05:40:47 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f41.google.com (HELO mail-pz0-f41.google.com) (209.85.210.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jan 2012 05:40:34 +0000
Received: by dang27 with SMTP id g27so3290463dan.0        for <binutils@sourceware.org>; Tue, 24 Jan 2012 21:40:34 -0800 (PST)
Received: by 10.68.189.69 with SMTP id gg5mr37451072pbc.41.1327470034383;        Tue, 24 Jan 2012 21:40:34 -0800 (PST)
Received: by 10.68.189.69 with SMTP id gg5mr37451043pbc.41.1327470034230;        Tue, 24 Jan 2012 21:40:34 -0800 (PST)
Received: from coign.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net. [71.133.8.30])        by mx.google.com with ESMTPS id i1sm3612885pbt.19.2012.01.24.21.40.32        (version=TLSv1/SSLv3 cipher=OTHER);        Tue, 24 Jan 2012 21:40:33 -0800 (PST)
From: Ian Lance Taylor <iant@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [gold patch] Add inlined fast path for LEB128 routines
References: <CAHACq4phYnC51NfOymtoPzmBkUcEug9_-jW2X_K_fnWqkXyM0A@mail.gmail.com>
Date: Wed, 25 Jan 2012 05:40:00 -0000
In-Reply-To: <CAHACq4phYnC51NfOymtoPzmBkUcEug9_-jW2X_K_fnWqkXyM0A@mail.gmail.com>	(Cary Coutant's message of "Tue, 24 Jan 2012 17:24:46 -0800")
Message-ID: <mcry5swuypb.fsf@dhcp-172-18-216-180.mtv.corp.google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00243.txt.bz2

Cary Coutant <ccoutant@google.com> writes:

> 2012-01-24  Cary Coutant  <ccoutant@google.com>
>
> 	* int_encoding.cc (read_unsigned_LEB_128): Replaced with inline
> 	definition and ...
> 	(read_unsigned_LEB_128_x): ... this new function.
> 	(read_signed_LEB_128): Replaced with inline definition and ...
> 	(read_signed_LEB_128_x): ... this new function.
> 	* int_encoding.h  (read_unsigned_LEB_128_x): New function.
> 	(read_unsigned_LEB_128): Add inline definition.
> 	(read_signed_LEB_128_x): New function.
> 	(read_signed_LEB_128): Add inline definition.
> 	* testsuite/Makefile.am (leb128_unittest): New unit test.
> 	* testsuite/Makefile.in: Regenerate.
> 	* testsuite/leb128_unittest.cc: New unit test.

> +  if (byte & 0x80)
> +    return read_unsigned_LEB_128_x(buffer, plen, byte);

Write ((byte & 0x80) != 0)

> +  if (byte & 0x80)
> +    return read_signed_LEB_128_x(buffer, plen, byte);

Here too.

This is OK with those changes.

Thanks.

Ian