public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: James Murray <jsm@jsm-net.demon.co.uk>
Cc: binutils@sourceware.org
Subject: Re: m68hc11 target / S12X / XGATE
Date: Mon, 31 Jan 2011 18:18:00 -0000	[thread overview]
Message-ID: <mcry661j5te.fsf@google.com> (raw)
In-Reply-To: <1296431324.9612.17.camel@jsm2> (James Murray's message of "Sun,	30 Jan 2011 23:48:44 +0000")

James Murray <jsm@jsm-net.demon.co.uk> writes:

> Ideally I would like to contribute my work back to the mainstream of
> code, but need guidance first. I have done some searches on the
> following, but not seen the answer - so pointers appreciated.
>
> - what is the test process to satisfy that the code is good

make check

although it's not very effective as it mostly tests the binutils for
consistency with themselves rather than for consistency with actual
hardware.  Ideally you would also test your binutils using gcc, by
running "make check" in gcc and ensuring that the execution tests pass.
However, I understand in this case that the gcc port is also broken.

Note that the gcc port is on the verge of being deprecated and removed,
so if you want to save it this would be a good time to speak up on
gcc.gnu.org.  See http://gcc.gnu.org/ml/gcc/2011-01/msg00391.html .

> - what authorisation process is used to validate my code changes?

Your changes can not be commited until they are approved by a binutils
maintainer.  The process is to send a patch to binutils@sourceware.org
and to ping the patch more or less weekly until a maintainer approves or
rejects it.

> - what "indent" commandline should I use on the C files I've altered ?

Usually running GNU indent with no options will do approximately the
right thing.

> - anything else?

You need to sign an FSF copyright assignment for your patches to be
accepted into the sources.  I can send you the form to start this
process if you need it.

The gcc contribution guidelines mostly apply to the binutils as well:
http://gcc.gnu.org/contribute.html (although as you know the binutils
still use CVS).

> Until now I've been using a 2.18 derivative, so I presume a first step
> would be to apply those changes to a CVS checkout and confirm it all
> works locally.

Yes.

Ian

  reply	other threads:[~2011-01-31 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30 23:46 James Murray
2011-01-31 18:18 ` Ian Lance Taylor [this message]
2011-01-31 19:03   ` James Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcry661j5te.fsf@google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=jsm@jsm-net.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).