From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20504 invoked by alias); 31 Jan 2011 18:18:08 -0000 Received: (qmail 20492 invoked by uid 22791); 31 Jan 2011 18:18:07 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 18:17:58 +0000 Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5]) by smtp-out.google.com with ESMTP id p0VIHtP4019803 for ; Mon, 31 Jan 2011 10:17:55 -0800 Received: from pvc21 (pvc21.prod.google.com [10.241.209.149]) by hpaq5.eem.corp.google.com with ESMTP id p0VIHU8O031341 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Mon, 31 Jan 2011 10:17:54 -0800 Received: by pvc21 with SMTP id 21so1174639pvc.31 for ; Mon, 31 Jan 2011 10:17:53 -0800 (PST) Received: by 10.142.86.7 with SMTP id j7mr6391608wfb.290.1296497872994; Mon, 31 Jan 2011 10:17:52 -0800 (PST) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id x18sm28619410wfa.11.2011.01.31.10.17.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 31 Jan 2011 10:17:52 -0800 (PST) From: Ian Lance Taylor To: James Murray Cc: binutils@sourceware.org Subject: Re: m68hc11 target / S12X / XGATE References: <1296431324.9612.17.camel@jsm2> Date: Mon, 31 Jan 2011 18:18:00 -0000 In-Reply-To: <1296431324.9612.17.camel@jsm2> (James Murray's message of "Sun, 30 Jan 2011 23:48:44 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00399.txt.bz2 James Murray writes: > Ideally I would like to contribute my work back to the mainstream of > code, but need guidance first. I have done some searches on the > following, but not seen the answer - so pointers appreciated. > > - what is the test process to satisfy that the code is good make check although it's not very effective as it mostly tests the binutils for consistency with themselves rather than for consistency with actual hardware. Ideally you would also test your binutils using gcc, by running "make check" in gcc and ensuring that the execution tests pass. However, I understand in this case that the gcc port is also broken. Note that the gcc port is on the verge of being deprecated and removed, so if you want to save it this would be a good time to speak up on gcc.gnu.org. See http://gcc.gnu.org/ml/gcc/2011-01/msg00391.html . > - what authorisation process is used to validate my code changes? Your changes can not be commited until they are approved by a binutils maintainer. The process is to send a patch to binutils@sourceware.org and to ping the patch more or less weekly until a maintainer approves or rejects it. > - what "indent" commandline should I use on the C files I've altered ? Usually running GNU indent with no options will do approximately the right thing. > - anything else? You need to sign an FSF copyright assignment for your patches to be accepted into the sources. I can send you the form to start this process if you need it. The gcc contribution guidelines mostly apply to the binutils as well: http://gcc.gnu.org/contribute.html (although as you know the binutils still use CVS). > Until now I've been using a 2.18 derivative, so I presume a first step > would be to apply those changes to a CVS checkout and confirm it all > works locally. Yes. Ian