From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 7FF573858407 for ; Tue, 8 Feb 2022 02:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FF573858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x634.google.com with SMTP id x3so12617121pll.3 for ; Mon, 07 Feb 2022 18:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=LXQSpjjQnetIgfaD/+8e2zAJrtACjdaBPoF30lyZKQ4=; b=G+4irL03ivBPmnDtl4s5hJFSaV0gdEH6mvndAdo7z1Twa3bUliPmtaFQaCcz/zq1x7 UcvMbVuEZu102GNFgA18MURgwI9R2ivhXT6DTajxgDuTBJFEFzKmcn+Iy4UN8skCHSil htOs0YXIPR+r+qqmSDX9ta9qt6/4rw/sbSuBv7sv4EkNNlNG5pE5jdObW8xFgtlrIMZX k5d3Fs+sfYszkWTa23nBDRxln44pO+/9e0RDpx6Z8LvphnuJfV05DBEVMRybWvUknIid 2/p0ItK707UeeesF+QRStGA7Dbyi4LuiutDuF3pNstl+C+Ampiv1DMGXwfVLF9+B/73S Ibmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=LXQSpjjQnetIgfaD/+8e2zAJrtACjdaBPoF30lyZKQ4=; b=jojheVha/KHg080U2DY1LUUYvui0W8FV4ioOgqNMw9tnEXzdfbKcb9IpG+YlfrS8qh vupT97P2GopkXRtN1Xwup+7iM7LKXo7Ju4jGedxnhVHBnuWruxzbqEikh6lXmZoi1WN3 filDAubpJ2dJ6lS5kLsR6zRtTsL4/TrYlzLKEezQ0eAVhp6ORgxDuoKNfxELyrDUGK9y xiHOR8k3W1/aF6xsWW3bO5xhOPyltxWp3LjIkcE7YmqjAQ3VKK4YmxqqsTZoufZcGZMM PP3kWTDLPIneTrJ1nbXaQcp42r9jqb1zbqMVit6sYvL+UlgQ9y2cCG/wE7s+ie3ZSrwA 1F/Q== X-Gm-Message-State: AOAM533WG7K+lb4oeUvH75gy9KiFzyhceUtVlX75K8/aLPbH/beId50/ 5SQqTklK31KdlfbggfaBKDlbsaSYnPik7A== X-Google-Smtp-Source: ABdhPJy77ht21al9uVYaKZa4jnAkxZHUG1bAy20pzlWYdbn1gScLInJZIexM9ibHsH0wbFiE7WLANg== X-Received: by 2002:a17:902:8603:: with SMTP id f3mr2543174plo.134.1644285654194; Mon, 07 Feb 2022 18:00:54 -0800 (PST) Received: from localhost ([12.3.194.138]) by smtp.gmail.com with ESMTPSA id oo7sm651436pjb.33.2022.02.07.18.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 18:00:53 -0800 (PST) Date: Mon, 07 Feb 2022 18:00:53 -0800 (PST) X-Google-Original-Date: Mon, 07 Feb 2022 15:57:21 PST (-0800) Subject: Re: [PATCH 5/5] RISC-V: Fix RV64_Zqinx to use register pairs In-Reply-To: <5a15b23e892bebb106433548fb3e3494281b7e4a.1643723292.git.research_trasio@irq.a4lg.com> CC: research_trasio@irq.a4lg.com, binutils@sourceware.org From: Palmer Dabbelt To: binutils@sourceware.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 02:00:57 -0000 On Tue, 01 Feb 2022 05:49:06 PST (-0800), binutils@sourceware.org wrote: > This commit ensures that all FP128 register numbers to be even because > RV64_Zqinx would require it. > > gas/ChangeLog: > > * testsuite/gas/riscv/zqinx.s: Make register numbers even. > * testsuite/gas/riscv/zqinx.d: Likewise. > --- > gas/testsuite/gas/riscv/zqinx.d | 70 ++++++++++++++++----------------- > gas/testsuite/gas/riscv/zqinx.s | 70 ++++++++++++++++----------------- > 2 files changed, 70 insertions(+), 70 deletions(-) > > diff --git a/gas/testsuite/gas/riscv/zqinx.d b/gas/testsuite/gas/riscv/zqinx.d > index c704241bc90..52b5445d010 100644 > --- a/gas/testsuite/gas/riscv/zqinx.d > +++ b/gas/testsuite/gas/riscv/zqinx.d > @@ -7,38 +7,38 @@ > Disassembly of section .text: > > 0+000 : > -[ ]+[0-9a-f]+:[ ]+06c5f553[ ]+fadd.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+0ec5f553[ ]+fsub.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+16c5f553[ ]+fmul.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+1ec5f553[ ]+fdiv.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+5e05f553[ ]+fsqrt.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+2ec58553[ ]+fmin.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+2ec59553[ ]+fmax.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+6ec5f543[ ]+fmadd.q[ ]+a0,a1,a2,a3 > -[ ]+[0-9a-f]+:[ ]+6ec5f54f[ ]+fnmadd.q[ ]+a0,a1,a2,a3 > -[ ]+[0-9a-f]+:[ ]+6ec5f547[ ]+fmsub.q[ ]+a0,a1,a2,a3 > -[ ]+[0-9a-f]+:[ ]+6ec5f54b[ ]+fnmsub.q[ ]+a0,a1,a2,a3 > -[ ]+[0-9a-f]+:[ ]+c605f553[ ]+fcvt.w.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+c615f553[ ]+fcvt.wu.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+c625f553[ ]+fcvt.l.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+c635f553[ ]+fcvt.lu.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+4035f553[ ]+fcvt.s.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+4235f553[ ]+fcvt.d.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+46058553[ ]+fcvt.q.s[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+46158553[ ]+fcvt.q.d[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d6058553[ ]+fcvt.q.w[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d6158553[ ]+fcvt.q.wu[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d625f553[ ]+fcvt.q.l[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d635f553[ ]+fcvt.q.lu[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+26c58553[ ]+fsgnj.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+26c59553[ ]+fsgnjn.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+26c5a553[ ]+fsgnjx.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+a6c5a553[ ]+feq.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+a6c59553[ ]+flt.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+a6c58553[ ]+fle.q[ ]+a0,a1,a2 > -[ ]+[0-9a-f]+:[ ]+a6b61553[ ]+flt.q[ ]+a0,a2,a1 > -[ ]+[0-9a-f]+:[ ]+a6b60553[ ]+fle.q[ ]+a0,a2,a1 > -[ ]+[0-9a-f]+:[ ]+26b58553[ ]+fmv.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+26b59553[ ]+fneg.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+26b5a553[ ]+fabs.q[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+e6059553[ ]+fclass.q[ ]+a0,a1 > +[ ]+[0-9a-f]+:[ ]+06e67553[ ]+fadd.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+0ee67553[ ]+fsub.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+16e67553[ ]+fmul.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+1ee67553[ ]+fdiv.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+5e067553[ ]+fsqrt.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+2ee60553[ ]+fmin.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+2ee61553[ ]+fmax.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+86e67543[ ]+fmadd.q[ ]+a0,a2,a4,a6 > +[ ]+[0-9a-f]+:[ ]+86e6754f[ ]+fnmadd.q[ ]+a0,a2,a4,a6 > +[ ]+[0-9a-f]+:[ ]+86e67547[ ]+fmsub.q[ ]+a0,a2,a4,a6 > +[ ]+[0-9a-f]+:[ ]+86e6754b[ ]+fnmsub.q[ ]+a0,a2,a4,a6 > +[ ]+[0-9a-f]+:[ ]+c6067553[ ]+fcvt.w.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+c6167553[ ]+fcvt.wu.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+c6267553[ ]+fcvt.l.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+c6367553[ ]+fcvt.lu.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+40367553[ ]+fcvt.s.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+42367553[ ]+fcvt.d.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+46060553[ ]+fcvt.q.s[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+46160553[ ]+fcvt.q.d[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+d6060553[ ]+fcvt.q.w[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+d6160553[ ]+fcvt.q.wu[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+d6267553[ ]+fcvt.q.l[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+d6367553[ ]+fcvt.q.lu[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+26e60553[ ]+fsgnj.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+26e61553[ ]+fsgnjn.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+26e62553[ ]+fsgnjx.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+a6e62553[ ]+feq.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+a6e61553[ ]+flt.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+a6e60553[ ]+fle.q[ ]+a0,a2,a4 > +[ ]+[0-9a-f]+:[ ]+a6c71553[ ]+flt.q[ ]+a0,a4,a2 > +[ ]+[0-9a-f]+:[ ]+a6c70553[ ]+fle.q[ ]+a0,a4,a2 > +[ ]+[0-9a-f]+:[ ]+26c60553[ ]+fmv.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+26c61553[ ]+fneg.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+26c62553[ ]+fabs.q[ ]+a0,a2 > +[ ]+[0-9a-f]+:[ ]+e6061553[ ]+fclass.q[ ]+a0,a2 > diff --git a/gas/testsuite/gas/riscv/zqinx.s b/gas/testsuite/gas/riscv/zqinx.s > index 02147b1919c..2dc2a7c1483 100644 > --- a/gas/testsuite/gas/riscv/zqinx.s > +++ b/gas/testsuite/gas/riscv/zqinx.s > @@ -1,36 +1,36 @@ > target: > - fadd.q a0, a1, a2 > - fsub.q a0, a1, a2 > - fmul.q a0, a1, a2 > - fdiv.q a0, a1, a2 > - fsqrt.q a0, a1 > - fmin.q a0, a1, a2 > - fmax.q a0, a1, a2 > - fmadd.q a0, a1, a2, a3 > - fnmadd.q a0, a1, a2, a3 > - fmsub.q a0, a1, a2, a3 > - fnmsub.q a0, a1, a2, a3 > - fcvt.w.q a0, a1 > - fcvt.wu.q a0, a1 > - fcvt.l.q a0, a1 > - fcvt.lu.q a0, a1 > - fcvt.s.q a0, a1 > - fcvt.d.q a0, a1 > - fcvt.q.s a0, a1 > - fcvt.q.d a0, a1 > - fcvt.q.w a0, a1 > - fcvt.q.wu a0, a1 > - fcvt.q.l a0, a1 > - fcvt.q.lu a0, a1 > - fsgnj.q a0, a1, a2 > - fsgnjn.q a0, a1, a2 > - fsgnjx.q a0, a1, a2 > - feq.q a0, a1, a2 > - flt.q a0, a1, a2 > - fle.q a0, a1, a2 > - fgt.q a0, a1, a2 > - fge.q a0, a1, a2 > - fmv.q a0, a1 > - fneg.q a0, a1 > - fabs.q a0, a1 > - fclass.q a0, a1 > + fadd.q a0, a2, a4 > + fsub.q a0, a2, a4 > + fmul.q a0, a2, a4 > + fdiv.q a0, a2, a4 > + fsqrt.q a0, a2 > + fmin.q a0, a2, a4 > + fmax.q a0, a2, a4 > + fmadd.q a0, a2, a4, a6 > + fnmadd.q a0, a2, a4, a6 > + fmsub.q a0, a2, a4, a6 > + fnmsub.q a0, a2, a4, a6 > + fcvt.w.q a0, a2 > + fcvt.wu.q a0, a2 > + fcvt.l.q a0, a2 > + fcvt.lu.q a0, a2 > + fcvt.s.q a0, a2 > + fcvt.d.q a0, a2 > + fcvt.q.s a0, a2 > + fcvt.q.d a0, a2 > + fcvt.q.w a0, a2 > + fcvt.q.wu a0, a2 > + fcvt.q.l a0, a2 > + fcvt.q.lu a0, a2 > + fsgnj.q a0, a2, a4 > + fsgnjn.q a0, a2, a4 > + fsgnjx.q a0, a2, a4 > + feq.q a0, a2, a4 > + flt.q a0, a2, a4 > + fle.q a0, a2, a4 > + fgt.q a0, a2, a4 > + fge.q a0, a2, a4 > + fmv.q a0, a2 > + fneg.q a0, a2 > + fabs.q a0, a2 > + fclass.q a0, a2 Aside from the previous Zqinx issues Reviewed-by: Palmer Dabbelt Thanks!