From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 6A8D03858C53 for ; Fri, 1 Apr 2022 04:15:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A8D03858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pl1-x62d.google.com with SMTP id i11so1455852plr.1 for ; Thu, 31 Mar 2022 21:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=VDxV8bBX4p7UTK1c1waHN9OJVuyvqWClyOFSLF9JU3w=; b=xn5bTyaSMuTyu2LjQLKy7RbeRhuA5LHi2WGzt61mH0+9j/vGMSxV5tunP+maqUE2Zx YICslIwgNb0VJ9bNHXUHqeJPaoe1lrNouO8x8k4PETFPEg3ZZ1RuBeuERdhMj750hIOo JKolRkxOSr8OCnaX8usQYZFO224CKx8D0atbO86nrQ262JDWeHojVy0CQSr4uXa6I+ZT ExqJCG2vtNJMLdO4LIuLS/iFfbPMsljPFAFNcUsrAWwq/2U7kMOTuTX4UqH4Qduo+BhA t4jtwl9EkCE60SfRtBHXa68cK2BMz00nBQNg3t56/GLqvMUODwUXHJ0OIoVgNdwVcB04 wd8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=VDxV8bBX4p7UTK1c1waHN9OJVuyvqWClyOFSLF9JU3w=; b=4hM+5M4cquScP1YzUWLSJEf51qU0dUP92dR+t7BIOxynS+LMO03ecU8gxz1gjCYYyJ nwwYc/TDkt5IiJUSCiVsdPWGVjqC8jF5qz0UfqW0v/FXtnZsTwMpbl9qb6EpyU3JCIHn ltzPod0/lQgZ78jB6W/vanOrhMpmwxLejQCvS9CZWdsi63vPdgA/SNh/VvqZ+vatFjA8 RDFKdnDrtDEArA6YB2RxXu06mxW/4xHnH6ZRty4QUvjnGLUMzkI164MFNHYdNhL/Mi2M iiju3g5nWQABTgON60B9Z3kWA6dEIuSYb479Wb8m24U+ZVEwDY54dTW+x7lwUJ7zwn9T k4SA== X-Gm-Message-State: AOAM530BbDlh+69WYqKjvQ4EMZIgxlU81OODAMzUyN/DmROOjGuIMLK2 JXflOYQfUEP/UKZaMlSPWl2Xj6KTcR2viA== X-Google-Smtp-Source: ABdhPJzAQ01RDDwZXjkbBCM5aKhVQKasCjYG46HBz8xJfQI23NJo2HzaDh8Zm9yebcgEMUm1DQMW7g== X-Received: by 2002:a17:90a:6393:b0:1bf:70e7:27d2 with SMTP id f19-20020a17090a639300b001bf70e727d2mr9799555pjj.1.1648786502710; Thu, 31 Mar 2022 21:15:02 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id ll19-20020a17090b21d300b001ca2a4777a7sm818701pjb.19.2022.03.31.21.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 21:15:01 -0700 (PDT) Date: Thu, 31 Mar 2022 21:15:01 -0700 (PDT) X-Google-Original-Date: Thu, 31 Mar 2022 21:14:59 PDT (-0700) Subject: Re: [PATCH 0/5] RISC-V: Add Ratified Cache Management Operation ISA Extensions (with paren) In-Reply-To: CC: binutils@sourceware.org From: Palmer Dabbelt To: Kito Cheng Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 04:15:06 -0000 On Thu, 31 Mar 2022 21:04:12 PDT (-0700), Kito Cheng wrote: > Nelson has merge this patch series: > > https://github.com/bminor/binutils-gdb/commit/41d6ac5da655a2e78109848f2db47e53552fd61a > https://github.com/bminor/binutils-gdb/commit/3b374308d3006407b9571e573e4ccce4e904a4c4 Thanks, I'd just looked for a email. I poked the spec folks, just to make sure we don't make a mess. > > On Fri, Apr 1, 2022 at 11:33 AM Palmer Dabbelt wrote: >> >> On Tue, 08 Feb 2022 18:29:27 PST (-0800), binutils@sourceware.org wrote: >> > This patchset is a modified version of: >> > >> > >> > GitHub: >> > (original; 2021-12-16, rebased) >> > (new: 2022-02-09) >> > >> > >> > There seems a discussion to change operand of cbo.* instructions on: >> > . >> >> Looks like that still hasn't been resolved? I don't really care either >> way, just that whatever we do is in agreement with the spec as it'd be >> silly to differ from LLVM here. >> >> > I have a little preference for old one but it's not bad to have both >> > options (as complete patchsets). >> > >> > Note that however, the original patchset is *NOT OUTDATED* yet. >> > It implements Zicbom/Zicboz instruction like: >> > >> > cbo.zero a0 >> > >> > This new patchset implements Zicbom/Zicboz instructions like: >> > >> > cbo.zero (a0) >> > cbo.zero 0(a0) # only zero is allowed >> >> There's some precedent for accepting both flavors of instructions like >> that, so if there's already an assembler out there that does things one >> way and the spec does the other I guess we could accept both? I'd still >> prefer to just have everyone agree on the specification side, though. >> >> > Actually, my first attempt to implement cbo.* instructions used the same >> > format as *new* patchset (I modified before submitting the first >> > patchset for compliance to the specification document). >> > >> > This version requires extra checking (0(a0) actually allows >> > EXPRESSION_RESULTS_IN_ZERO(a0)) so I added a few extra tests. >> > It will also reject operand format in older patchset. >> > >> > Old patchset and new patchset are mutually exclusive and should follow >> > the conclusion of the discussion above. >> > >> > Thanks, >> > Tsukasa >> > >> > >> > >> > >> > Tsukasa OI (5): >> > RISC-V: Add mininal support for Zicbo[mpz] >> > RISC-V: Cache management instructions >> > RISC-V: Cache management instruction testcases >> > RISC-V: Prefetch hint instructions and operand set >> > RISC-V: Prefetch hint instruction testcases >> > >> > bfd/elfxx-riscv.c | 9 +++++++++ >> > gas/config/tc-riscv.c | 18 ++++++++++++++++++ >> > gas/testsuite/gas/riscv/zicbom-fail.d | 3 +++ >> > gas/testsuite/gas/riscv/zicbom-fail.l | 7 +++++++ >> > gas/testsuite/gas/riscv/zicbom-fail.s | 7 +++++++ >> > gas/testsuite/gas/riscv/zicbom.d | 15 +++++++++++++++ >> > gas/testsuite/gas/riscv/zicbom.s | 7 +++++++ >> > gas/testsuite/gas/riscv/zicbop-fail.d | 3 +++ >> > gas/testsuite/gas/riscv/zicbop-fail.l | 4 ++++ >> > gas/testsuite/gas/riscv/zicbop-fail.s | 4 ++++ >> > gas/testsuite/gas/riscv/zicbop.d | 12 ++++++++++++ >> > gas/testsuite/gas/riscv/zicbop.s | 4 ++++ >> > gas/testsuite/gas/riscv/zicboz-fail.d | 3 +++ >> > gas/testsuite/gas/riscv/zicboz-fail.l | 3 +++ >> > gas/testsuite/gas/riscv/zicboz-fail.s | 3 +++ >> > gas/testsuite/gas/riscv/zicboz.d | 12 ++++++++++++ >> > gas/testsuite/gas/riscv/zicboz.s | 4 ++++ >> > include/opcode/riscv-opc.h | 16 ++++++++++++++++ >> > include/opcode/riscv.h | 3 +++ >> > opcodes/riscv-dis.c | 4 ++++ >> > opcodes/riscv-opc.c | 9 +++++++++ >> > 21 files changed, 150 insertions(+) >> > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.d >> > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.l >> > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.s >> > create mode 100644 gas/testsuite/gas/riscv/zicbom.d >> > create mode 100644 gas/testsuite/gas/riscv/zicbom.s >> > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.d >> > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.l >> > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.s >> > create mode 100644 gas/testsuite/gas/riscv/zicbop.d >> > create mode 100644 gas/testsuite/gas/riscv/zicbop.s >> > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.d >> > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.l >> > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.s >> > create mode 100644 gas/testsuite/gas/riscv/zicboz.d >> > create mode 100644 gas/testsuite/gas/riscv/zicboz.s >> > >> > >> > base-commit: a37603c43f8da7983ed53b567ea30ce66066daa2