From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 6BD513883022 for ; Fri, 30 Jun 2023 22:16:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BD513883022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1b82bf265b2so12468555ad.0 for ; Fri, 30 Jun 2023 15:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1688163405; x=1690755405; h=message-id:to:from:cc:in-reply-to:subject:date:from:to:cc:subject :date:message-id:reply-to; bh=tqZnZDurg0JK0T5EbetgBX2TD1GARkLmEVi8cXIj2Kg=; b=HsempfmGRcktv99yqqxoz3wT2crRc2/sOvu+VZpreQkmC4XXoqeZ/1C/bhyKZiBNQI f6bL/J1+VrZirJBDZm/oKg0A8Qkkn1PlMcKMGrT7eWD8DCa2TxJsx/nG+VN9U0zfZFQG M5YfDIhVMjJeb/VD1K9Y9uMvUxRkWVvQljKK2m56/dA+ukByyJogVM4tWNo+8l0gSnvA otKqSrNkiIw4Uoy7AVGfSWlkPeM7tg1Z6Vt5+FAbzhn+eO0cXeqOWDeXk0nXXQ4xxPpl WKTEbhxHXlr67qYxSsjVzehd7VYTqyUkz8J5OdtV2Snkn99dvROU3hq4zf1Mz82WR66x p2ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688163405; x=1690755405; h=message-id:to:from:cc:in-reply-to:subject:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tqZnZDurg0JK0T5EbetgBX2TD1GARkLmEVi8cXIj2Kg=; b=ZphrBFXuXjCn7OccQplSeGv4fW1mNbnpwPGmwDax4UaVcagwYaS86wRqRpyxTsU9ZV 8i9/7CQo9xozGrkyD3hpbXxp0TqTNmnHHzje9DfrwGSXBtKzDhVF6bF61rJCt3drsnkA Hq/8WIt62olEG2F2lz1Y6RGoK7zblj7kuWa/LseNaOcxApUYWPTghoKOQHe0zaeDWgXE uhCuc8wxLgMsz9mu9HH1kQVc9cn8C7OgW+5I+md26LIAzXtMmRpdVMy/aTI/MoA98mC3 8yBK8x9Tu14ORR7/27JfqxrINFbo/BYVGaC8ujw0K9BsFn9jnQQyuwlbEVV5nAbDTwlh F6ag== X-Gm-Message-State: ABy/qLY0Hoi4DI/ibjBvNCaGZuTObOX6DInJUW4wzBtlQ1JTp2k9tgn6 YRiz/B8Uwd5YOBx8wm4QF23gzw== X-Google-Smtp-Source: APBJJlE0uBZVup+TnQZ1OSrw8xarSRK7x3gJvjhhgW15FEDFGRFctGQ709TAtHdWdSJk/6kIQPDPHw== X-Received: by 2002:a17:902:c1cd:b0:1ac:7245:ba5a with SMTP id c13-20020a170902c1cd00b001ac7245ba5amr2495072plc.61.1688163405303; Fri, 30 Jun 2023 15:16:45 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id az10-20020a170902a58a00b001b1866f7b5csm11153292plb.138.2023.06.30.15.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 15:16:44 -0700 (PDT) Date: Fri, 30 Jun 2023 15:16:44 -0700 (PDT) X-Google-Original-Date: Fri, 30 Jun 2023 15:16:01 PDT (-0700) Subject: Re: [PATCH 01/14] Add support for the Zvbb ISA extension. In-Reply-To: CC: jeffreyalaw@gmail.com, nhuck@google.com, binutils@sourceware.org, nhuck@pmull.org From: Palmer Dabbelt To: christoph.muellner@vrull.eu Message-ID: X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,PP_MIME_FAKE_ASCII_TEXT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 30 Jun 2023 15:01:43 PDT (-0700), christoph.muellner@vrull.eu wrote: > On Fri, Jun 30, 2023 at 10:57 PM Jeff Law wrote: >> >> >> >> On 6/30/23 14:29, Christoph Müllner wrote: >> > On Fri, Jun 30, 2023 at 7:51 PM Jeff Law wrote: >> >> >> >> >> >> >> >> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: >> >>> From: Christoph Müllner >> >>> >> >>> Zvbb is part of the vector crypto extensions. >> >>> >> >>> This extension adds the following instructions: >> >>> - vandn.[vv,vx] >> >>> - vbrev.v >> >>> - vbrev8.v >> >>> - vrev8.v >> >>> - vclz.v >> >>> - vctz.v >> >>> - vcpop.v >> >>> - vrol.[vv,vx] >> >>> - vror.[vv,vx,vi] >> >>> - vwsll.[vv,vx,vi] >> >>> >> >>> Signed-off-by: Christoph Müllner >> >>> [Updated to newest version of RISC-V spec] >> >>> Signed-off-by: Nathan Huckleberry >> >>> --- >> >>> bfd/elfxx-riscv.c | 5 ++++ >> >>> gas/config/tc-riscv.c | 13 +++++++++ >> >>> gas/testsuite/gas/riscv/zvbb.d | 43 +++++++++++++++++++++++++++++ >> >>> gas/testsuite/gas/riscv/zvbb.s | 34 +++++++++++++++++++++++ >> >>> include/opcode/riscv-opc.h | 50 ++++++++++++++++++++++++++++++++++ >> >>> include/opcode/riscv.h | 5 ++++ >> >>> opcodes/riscv-dis.c | 4 +++ >> >>> opcodes/riscv-opc.c | 18 ++++++++++++ >> >>> 8 files changed, 172 insertions(+) >> >>> create mode 100644 gas/testsuite/gas/riscv/zvbb.d >> >>> create mode 100644 gas/testsuite/gas/riscv/zvbb.s >> >> This needs appropriate ChangeLog entries as well as an update to the >> >> binutils/NEWS file. With those missing pieces this will be OK for the >> >> trunk. >> > >> > I will provide that: >> > * Adding ChangLog entries to the commit messages >> > * Adding a commit that updates binutils/NEWS >> > >> > I will send a new version on the list within the next hour. >> Sounds good. Feel free to push them yourself. Or if you don't have >> time, I'll get to them at some point before Nick branches on Sunday :-) > > I have sent out v5, but I need someone else to push as I don't have > write access. > For convenience the changes can be found here as well: > https://github.com/cmuellner/binutils-gdb/tree/riscv-zvk-v5 I just kicked off a test suite run, if it all passes I'll commit it -- but if I forget then someone else is welcome to ;) > > Thanks, > Christoph