From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 29D883858D38 for ; Mon, 3 Oct 2022 17:40:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29D883858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pl1-x62f.google.com with SMTP id x1so10317300plv.5 for ; Mon, 03 Oct 2022 10:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date; bh=WxwUr9p6zw+rZTKgPRY1AbsLA2MGbB4LieB3b1PwFiY=; b=Bj5MxMkWGepz6+QA6JV9FuAZKAuKtiO4X+0+AbcTYBkTLBriofBRjiIs3kYEtfH9z0 mGLjhEOqV9j+QAL6V6wImajTtHEmbRyBuxsXH6WA1BSGlTlu4ZBYYGAVNll0Wdsf+8JC 786BDSkh75kVKk2iuaj/bP+KmhgsSDG1ElKFUPwizNLPpQDTgLmtrMjDYzzHN9qzDS8J S9W+4rkeABAGTKIFoaJf4+gNlUGBcJalkfmkaOJxwPnpHBHJRIDMxsAGDrMe9Z+DWGbb ogwKVsMUdZNKJdR7FIdMqSYCbi/IbSyTVo1mkuDTzue06xIsw6E1ngnzTpJyTHzQtjat SW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date; bh=WxwUr9p6zw+rZTKgPRY1AbsLA2MGbB4LieB3b1PwFiY=; b=AtaZLpQkJUaIE6r5HCgveTs9MdEv+uVGyc1rdUz19QocHElyNDPfkHMwKNzxa4qE3O /Ar7K0ZpAHyfnz0zm8XOYxXHVZ5ynER80nD4lKGoHjpO4zsebsECN7tgNk428wEAdDFX ozWozLdDEFnVS82yKfOE9j6Gfu+Leb2EhrNqGB703k84/6COq44MqPHep+nVYwRpDIqh mS58vDsrBFEFoBXUftY9dSF+55L4xr94myMhfRCrzCHaOgL5y7zszU72Klagu12Ju9MH okrd42s4mgGblR81FhB9IM+ETk4IxSyCRLqt43UPOPJqmY1mOGQ476BMEc38Ea38Ejvr jikQ== X-Gm-Message-State: ACrzQf3kHkye3E7ySGyEQsNgJIQxfjzvHPvmwahqnGxvBMPbUh9nzqJg SB41bO4Kbca1nhk4CzO+X/2UAfwfm6pagons X-Google-Smtp-Source: AMsMyM6YpMm6oAZcxzYVJKjizbxUpQyS3I8p5XOx2G8cyflfTl3cPPPWyydPTSR2P9ZTT6CHRG5jNQ== X-Received: by 2002:a17:90a:a788:b0:20a:20f5:4f15 with SMTP id f8-20020a17090aa78800b0020a20f54f15mr13396624pjq.91.1664818816466; Mon, 03 Oct 2022 10:40:16 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id c145-20020a621c97000000b0055ff55f3b18sm5023689pfc.188.2022.10.03.10.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 10:40:15 -0700 (PDT) Date: Mon, 03 Oct 2022 10:40:15 -0700 (PDT) X-Google-Original-Date: Mon, 03 Oct 2022 10:40:13 PDT (-0700) Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles In-Reply-To: <87h70lgrd5.fsf@redhat.com> CC: binutils@sourceware.org, research_trasio@irq.a4lg.com, nelson@rivosinc.com, kito.cheng@sifive.com, binutils@sourceware.org From: Palmer Dabbelt To: aburgess@redhat.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote: > Tsukasa OI via Binutils writes: > >> Hello, >> >> This patchset fixes various typing and styling errors on the RISC-V >> disassembler. > > I can't approve binutils patches. > > I've taken a look through this series, and other than the minor typo I > spotted, this all looks good to me. My worry with these things is that it's sort of a grey area in terms of what our stable user interface is: there's definitely folks who try and parse the text output of tools like objdump and changing anything risks breaking that. IMO that's too strict of a stable interface to keep around as it pretty much prevents us from fixing any disassembly weirdness, but I'm not sure if that's what other ports do and I don't want to make a mess by breaking users' expectations here. That said, as far as I can tell the only user-visible change here is to print some bits with the correct syntax coloring in GDB. Seems pretty straight-forward to say anything users can't rely on parsing syntax highlighting colors being a stable interface, so maybe we can just punt on the grey area for now ;) > Thanks for doing this. Yep. These LGTM, but I'm still kind of buried thanks to the a few weeks of conference->COVID. They're probably fine, but hopefully Nelson has the time to chime in -- if not I'll leave them in the queue. Thanks! > > Andrew > > > >> >> Previous Patchsets: >> (2022-07-13) >> (2022-08-03) >> Tracker on GitHub: >> >> >> >> [Changes: v1 -> v2] >> >> - Added PATCH 5-6/6 after T-Head extensions are merged. >> - Slightly improved the commit messages? >> >> >> [Styling] >> - Print real immediates with the `immediate' style (PATCH 1/6) >> - Print comma and tabs with the `text' style (PATCH 4/6) >> - Print T-Head literal operand with `immediate' style (PATCH 6/6) >> [Typing on printf] >> - Fix wrong type for "%x" format specifier (PATCH 2/6) >> - Fix minor but various typing issues on T-Head immediates (PATCH 5/6) >> [Small Optimization] >> - Use smallest portable types possible to print (PATCH 3/6) >> >> Thanks, >> Tsukasa >> >> >> >> >> Tsukasa OI (6): >> RISC-V: Fix immediates to have "immediate" style >> RISC-V: Fix printf argument types corresponding %x >> RISC-V: Optimize riscv_disassemble_data printf >> RISC-V: Print comma and tabs as the "text" style >> RISC-V: Fix T-Head immediate types on printing >> RISC-V: Print XTheadMemPair literal as "immediate" >> >> opcodes/riscv-dis.c | 71 +++++++++++++++++++++++++-------------------- >> 1 file changed, 39 insertions(+), 32 deletions(-) >> >> >> base-commit: c21736aed1d4877e090df60362413669dbdc391d >> -- >> 2.34.1