From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id DD1F03858017 for ; Tue, 8 Feb 2022 02:00:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD1F03858017 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x42b.google.com with SMTP id n32so16214005pfv.11 for ; Mon, 07 Feb 2022 18:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=peLPV0ImuRAK4mJUz0p2iZG7BGWOAdW19GDHpaB8RJQ=; b=HtTTn5LhdAAme6nE+D7S9Pt+4aFVhKTBIiezwBZW5HV2Q7D3M7YKmUWgZ02kAgcf9N +Y8Ks+0Duk4mYE6xc9knw+Jn76YxkjtVZ+aOXk05MlzaTxAb26Z4+c7o0lyW/A+FBaAX u8JyuWn3ThZ25DYF+rQejAkRPnlIKveHqDc2NaToCDbexJCJ0oboND2/WgSfCSzyoqLf lP04fR09sZPWoITNZ7HGS6uer1OXyWN2LmprQDtDSRgZ7lqxHnZI3HNZ6Qer33akAOsz EUekNFOQwljbTaYnDQZnL1SKnKqwJIm4GopGCZ3RqNPifIguv0pV6wbkr66FXrU6mTWM lC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=peLPV0ImuRAK4mJUz0p2iZG7BGWOAdW19GDHpaB8RJQ=; b=W2MfmRfErF8bUFSnbFLg2LVAVt1utla7HTTGWYyHVS5eaxK94yDfX0B0THcUL1Gbt+ /a6Ru6QuW/uNOm8wXgVeFN0fpCy1Ir2a6p/fbT+oQIys2zXYDBhQhTr8bBRBd3V1pucf bg8OEzKrCTPUvQZmFIhTORtbyDY/1lHWM61S3V8lIDkR+4CQ68nJ75RjNe4UUoKy3vxG wNeIz7e+z6Jm8CY/Ai9H6svMWSKG1WBp5m7qOavrrC+QuOGBmAuBL8bEDp+GUhEfLpaZ dsQ93QhhrkZZlg7PPusxZl5OFqaNPgBAI6OJh7bPZfWcIxKzZEjDt5UpfN+QITX+oQsk LHTw== X-Gm-Message-State: AOAM532Rz/vXi6EbSVjwy4a8n67GgMtoCwCnfTaUo+kBrklQkxWZzKfL 9clpW4KYCivz2KNROfaZmAcH8w== X-Google-Smtp-Source: ABdhPJwns8lkzUnfbcPs7jRygqG+EQV0s1rdT0eH+TZLRItBS/lmA//VyByj+jzn1bf4+phqpic/Nw== X-Received: by 2002:a62:b618:: with SMTP id j24mr2254319pff.69.1644285657949; Mon, 07 Feb 2022 18:00:57 -0800 (PST) Received: from localhost ([12.3.194.138]) by smtp.gmail.com with ESMTPSA id 16sm3005094pfm.200.2022.02.07.18.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 18:00:57 -0800 (PST) Date: Mon, 07 Feb 2022 18:00:57 -0800 (PST) X-Google-Original-Date: Mon, 07 Feb 2022 16:45:13 PST (-0800) Subject: Re: [PATCH 2/4] RISC-V: Add disassembler tests for Zdinx regs In-Reply-To: <0224765598be7e004b28401f045ffede73a6e6f7.1643723585.git.research_trasio@irq.a4lg.com> CC: research_trasio@irq.a4lg.com, binutils@sourceware.org From: Palmer Dabbelt To: binutils@sourceware.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 02:01:00 -0000 On Tue, 01 Feb 2022 05:53:36 PST (-0800), binutils@sourceware.org wrote: > This commid adds disassembler tests for invalid Zdinx register numbers > (make sure that we don't disassemble invalid encodings). > > gas/ChangeLog: > > * testsuite/gas/riscv/zdinx-32-regpair-dis.s: New test to make > sure that invalid encoding is not disassembled. > * testsuite/gas/riscv/zdinx-32-regpair-dis.d: Likewise. > --- > gas/testsuite/gas/riscv/zdinx-32-regpair-dis.d | 11 +++++++++++ > gas/testsuite/gas/riscv/zdinx-32-regpair-dis.s | 5 +++++ > 2 files changed, 16 insertions(+) > create mode 100644 gas/testsuite/gas/riscv/zdinx-32-regpair-dis.d > create mode 100644 gas/testsuite/gas/riscv/zdinx-32-regpair-dis.s > > diff --git a/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.d b/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.d > new file mode 100644 > index 00000000000..018a0e51f03 > --- /dev/null > +++ b/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.d > @@ -0,0 +1,11 @@ > +#as: -march=rv32ima_zdinx > +#source: zdinx-32-regpair-dis.s > +#objdump: -dr -Mnumeric > + > +.*:[ ]+file format .* > + > +Disassembly of section .text: > + > +0+000 : > +[ ]+[0-9a-f]+:[ ]+02627153[ ]+fadd.d[ ]+x2,x4,x6 > +[ ]+[0-9a-f]+:[ ]+0272f1d3[ ]+\.4byte[ ]+0x272f1d3 > diff --git a/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.s b/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.s > new file mode 100644 > index 00000000000..aa0c72cae87 > --- /dev/null > +++ b/gas/testsuite/gas/riscv/zdinx-32-regpair-dis.s > @@ -0,0 +1,5 @@ > +target: > + # fadd.d x2, x4, x6 > + .insn 0x02627153 > + # fadd.d x3, x5, x7 (invalid) > + .insn 0x0272f1d3 Reviewed-by: Palmer Dabbelt