From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 5CEC63858CDA for ; Mon, 25 Sep 2023 09:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CEC63858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1c44c0f9138so40777645ad.2 for ; Mon, 25 Sep 2023 02:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1695635584; x=1696240384; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=qdcXE9Cp6syS9H4qelwt1Q/PKg2WzNZYiAQRsFIA/jI=; b=0aKvrbwAJ2EjJznC6Tj6tGHTC135p5cID9jsHuX+/w+sVTvooVgv/gmRAdW3S6vi/E iNIl1rH8wtzw7XFmkFrZgh9Clcw3FZIpW54dKG6FSS74QBV1evTAzM7GEs2SP/jg2Ige BdRg/6TDGAE7n/NsqK0JogLQLDdAOzE0F3AaGjYtLuvH/mv3wRFUQO4dtxNVDw1hmqD6 ub4tWmSG6/JZTG5KK0/cnVlXzT9aUEsZiFzO4+hTcNXSrvkYuDSEzDaBIT2ovVZsAmhE yagV40uCLZNdKGbVBWvrc55wZmwBi4qLBWAMWtf9d8U1KlgbLQrTevtvmfPufDazNEhW /2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695635584; x=1696240384; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qdcXE9Cp6syS9H4qelwt1Q/PKg2WzNZYiAQRsFIA/jI=; b=MfyAU7LNybXS23FYwSJEfQkWT7gKeyT/lKLHVPGDoOh8iN2aZcmkbacp/vNL8t+Pbb giGdC4GSs5VY9BMx3IJexJ9w4RsoYq/ukgEPfaZXe6ouWVZcFPgg5B+XYcltdbt4CQ+a xc/NY8CHUPFzbekH04gAhkUPknCe2BGJqgGKhWZJsC61SHkJvEdnM6gaXbLce5qzzbqw 6Tk0qvHDcHMb1cNHwjqqV2rAkSCK8imCKqo2ZvStMxyZLtQ1UU6mrUxqxTd+n3CcXFAb +BDuZioPVP2BmCpgzKs9n1HxBHenxVqm0NhTEDJddOklpEetEbFTuhE87eIThHdLWiRI YTWw== X-Gm-Message-State: AOJu0Yz/9liK6gz4SG2e76+Jkdjqg/mc9i3TFrhi6ZvvlJPA57uGZJv/ XLR/eN8enRw4up0SNOvsGBtBV2ulPOqQRl4KYQaQiQ== X-Google-Smtp-Source: AGHT+IHwZ05qa9+StXDCFbgf8tWzkNdDhoYcdyIux+Az5OImFIHajHv4/BDuzIpVeHwwy0bSrlF4YA== X-Received: by 2002:a17:902:7584:b0:1c5:9db0:a1c3 with SMTP id j4-20020a170902758400b001c59db0a1c3mr3686326pll.35.1695635583931; Mon, 25 Sep 2023 02:53:03 -0700 (PDT) Received: from localhost ([51.52.155.79]) by smtp.gmail.com with ESMTPSA id i11-20020a17090332cb00b001bc0f974117sm8391743plr.57.2023.09.25.02.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 02:53:03 -0700 (PDT) Date: Mon, 25 Sep 2023 02:53:03 -0700 (PDT) X-Google-Original-Date: Mon, 25 Sep 2023 02:53:00 PDT (-0700) Subject: Re: [PATCH] RISC-V: Protect .got with relro In-Reply-To: CC: binutils@sourceware.org, nelson@rivosinc.com From: Palmer Dabbelt To: schwab@suse.de Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 25 Sep 2023 02:47:11 PDT (-0700), schwab@suse.de wrote: > On Sep 25 2023, Palmer Dabbelt wrote: > >> I think we also want something like this >> >> diff --git a/ld/testsuite/ld-elf/binutils.exp b/ld/testsuite/ld-elf/binutils.exp >> index 674e8e9a575..b38e29ed6fb 100644 >> --- a/ld/testsuite/ld-elf/binutils.exp >> +++ b/ld/testsuite/ld-elf/binutils.exp >> @@ -95,7 +95,6 @@ proc binutils_test { prog_name ld_options test {test_name ""} {readelf_options " >> || [istarget "mips*-*-*"] \ >> || [istarget "nios2*-*-*"] \ >> || [istarget "or1k-*-*"] \ >> - || [istarget "riscv*-*-*"] \ >> || [istarget "sh*-*-*"] \ >> || [istarget "x86_64-*-rdos*"])] >> # Check if GNU_RELRO segment is generated. > > Thanks, I will squash that in. Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Thanks!