From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id AF9AF385843B for ; Mon, 4 Dec 2023 17:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF9AF385843B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF9AF385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701710182; cv=none; b=sZMzkAWnISbjbOv7DJN9T3oNAVTg07YdqKysFBXlYCV5MNXZxZu/d/QaqQYsjLk8SDUikB9y0KoqUTCF3nXynlIKk7eUp3/pGpxaJVBrPPcIkuCg7oD4+SBXjX25oU4H5ZF6BmvhioMeIRN5E9qUW7G5j1muQuw4LHb5IDgL3eo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701710182; c=relaxed/simple; bh=bK/NWK6oQylcew9Jtp8OT6f693Zle/Ch7yTj1lc1Q98=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=h4gPe3p3b3yNHrfkqklof8ly0CS7IPfoc8BkRBDrQYPzq1Z82cRrkl/vS6VKrhSW7MtSmt726iCQBnW8DPAmBsi8E7RiftcmgcMNpiJdilIh+bJIL/OpzVhbIVyZ1qiYL1kkmynqPKV7ZDPtcRUp8HA6sywY4qqlaaN6Alt6qHA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b8b0ced0f4so1042595b6e.0 for ; Mon, 04 Dec 2023 09:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1701710179; x=1702314979; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=jJ3WMgz8GBzZ0zj7Q+PZQZCnQs6wPN53TEUmOSEYj9g=; b=uWhRrIr0KrOk3aNSFTW5yic+YueRpLZG+xr555SxO1J9kVTO6v18Mhb9wMVu/Y28pM DkkqC0uAPurhiMslYUhKGlnn62R1d6vcK9s7K1FJLw5cCLaz0XZZ32BSuWYOyyw2FCLL LG/E9fxbVXE+snUiRa4E0lJNTIbYyuSzmre/blVl8X6Qsp/96frzYhxtJeuXoPuy0ypM uHULoZ6QsArmmIdkUHhs1Xsrnzton44Z/1aBNrnTNcwKri60KuPOkbIKVRBe4XjSV4Tx yaHm8NMlliIhWtI2f1XylfrpW0aOsf8TA+oNJ89k4ifwAhtv3trWAHqhzJeVVFshzpfM ICxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701710179; x=1702314979; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jJ3WMgz8GBzZ0zj7Q+PZQZCnQs6wPN53TEUmOSEYj9g=; b=EpjpuKd37fvGHaF4wPWxOvnHZtvm2C2BI7u7f91TjRGAGhIOjfhYrF3Uq5ZC+x6yMy 1xcDq2Ba1HWlYtwcRoS7uWUr8h3iD+RQEyt6DSuCzu4Q8F+fbOgQ3ctY3iWobkALHeZN V2SmG/fnSUXn1zwvtEfE4GSr+Pp6v/vUhLJ1X5OpL+4qe+X7d6fRhjq4TNiUbH7AxTe2 QqUku6WW2SPBs6v5VGsEH7FYWSIz0xUMzqoQb2fPmFmaPRUD9CsmLO0QKGrumO3/TG8m RBfhnWQJ9hkcHovt8m8qMLgooi9eLcDoD8YEQTqRVXnzhW20ZURQJ0ZbUPugwPRpTVpD HgLg== X-Gm-Message-State: AOJu0YwIP3VLlJ9iruAzfuHE2j1e86LnmPAjlZduggTDa4z0BKtOuBoO i9IHmz5VOvUyyq3K4czfu+gcE43DYHJFrTMLVq0= X-Google-Smtp-Source: AGHT+IE2kZtZQex4NaBUkrAJYC15i/vkUZAUnI/s2Wh0eFkKWS0FA5l41telWKhTx3XJLy95l65zAg== X-Received: by 2002:a05:6871:7999:b0:1fa:3691:9fb2 with SMTP id pb25-20020a056871799900b001fa36919fb2mr20663oac.25.1701710174685; Mon, 04 Dec 2023 09:16:14 -0800 (PST) Received: from localhost ([192.184.165.199]) by smtp.gmail.com with ESMTPSA id lf4-20020a0568700c4400b001fb3a053eaesm926988oab.34.2023.12.04.09.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 09:16:13 -0800 (PST) Date: Mon, 04 Dec 2023 09:16:13 -0800 (PST) X-Google-Original-Date: Mon, 04 Dec 2023 09:16:10 PST (-0800) Subject: Re: [PATCH] Handle "efi-app-riscv64" and similar targets in objcopy. In-Reply-To: <20230906200134.1033297-2-pjones@redhat.com> CC: binutils@sourceware.org, schwab@suse.de, pjones@redhat.com From: Palmer Dabbelt To: pjones@redhat.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 06 Sep 2023 13:01:34 PDT (-0700), pjones@redhat.com wrote: > This adds the efi target name handling for riscv64 to objcopy. > > binutils: > * binutils/objcopy.c: add riscv64 handling to > convert_efi_target() > > Signed-off-by: Peter Jones > --- > binutils/objcopy.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > index 2ce1b07bf7c..b64cbee3dd7 100644 > --- a/binutils/objcopy.c > +++ b/binutils/objcopy.c > @@ -5129,6 +5129,11 @@ convert_efi_target (char **targ) > /* Change aarch64 to aarch64-little. */ > memcpy (pei + 4 + sizeof ("aarch64") - 1, "-little", sizeof ("-little")); > } > + else if (strcmp (efi + 4, "riscv64") == 0) > + { > + /* Change riscv64 to riscv64-little. */ > + memcpy (pei + 4 + sizeof ("riscv64") - 1, "-little", sizeof ("-little")); > + } > *targ = pei; > return subsys; > } Sorry I missed this, David just poked me. Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Thanks!