From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 48D763858414 for ; Tue, 27 Jun 2023 14:48:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48D763858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1b7e1875cc1so15527665ad.1 for ; Tue, 27 Jun 2023 07:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1687877311; x=1690469311; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=mDf3ygZ1lF93qwBnucJXIVhT8NdvpZmeKttDeZ3Kth0=; b=3Gy18c/to9iji2kYWPF2e/L/KoGFPo4D5tGYl9+LjGSJPEJyQym/KDzZqVgkeEl7i5 S7f3tsY/9oApV1thyMP/uIZtZDM4y+1a9l2c9yYyc0fPDN9rsNcBqlGGvLoVNorFWbQP TAYbWVb8CiSb2+0uRLK6b2n1N4UlcZtFZ+Vlb3cCl8VlrCsAIA8VxZM6NoAb8CgE7DuK GSS4//Duch+HYXm52PV+bf+15geTgRRzWPKRhV18+MxwdxJScaHqI0jY0v5d9vxluIKW Fl42I0SzusDqpOvcU91reAn5uoJpVOiToCNFu4Dq/cV8vw/g4bcDRH5reUwTSSU2jiMC pqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687877311; x=1690469311; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mDf3ygZ1lF93qwBnucJXIVhT8NdvpZmeKttDeZ3Kth0=; b=fQAAgay3xeIRNWOYO41ZS3pPLbDWtR7jCEc9xnIkCSBfSwL34Q0D/r2aeNxbLPYHYv gcfBI5WYbN1uWhAfdLwVXxn5qzywiiW6YmqHowfbEx1LYw8lK21AfZ0cYNhcOHEBXex7 QiDBopu3ZNRkQATmUnLCvfCuWiCCjbIs1h+WBeNukpeQ7cZFt0IE05IFhgwab51PCawV HyvsB/ec0AN0pKuhCFuLB9nvmDKRhde9MZQjXqzUoyUIz9mpNEXVQhmb7avsk5aQB6kZ 7b3huVZPfWz4utMhlmbUFLtIIdTj7kfF/jKTAYjN+RFqUGMgpDeR+4I2czMytUjRKCSO bd5A== X-Gm-Message-State: AC+VfDzyGzgVHaqEX5B6XwsbkL8Sh1PpOPh7hKc08Bj+j9sGX9uw9sjf F048LcWnOfljjlqn8ZgdRL3hTO87FhLKCQ+SujY= X-Google-Smtp-Source: ACHHUZ5WlEIFzEXrA9TCEaU9gkSJv3vVZh/1xPY10JIVA9UkkY5njwa66o4TdIkrOR2KZM5Tnv8LZg== X-Received: by 2002:a17:902:e746:b0:1b6:6963:4cc0 with SMTP id p6-20020a170902e74600b001b669634cc0mr7264115plf.53.1687877310911; Tue, 27 Jun 2023 07:48:30 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id k16-20020a170902761000b001b3f9a5d4besm6070494pll.255.2023.06.27.07.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 07:48:30 -0700 (PDT) Date: Tue, 27 Jun 2023 07:48:30 -0700 (PDT) X-Google-Original-Date: Tue, 27 Jun 2023 07:48:28 PDT (-0700) Subject: Re: [RFC PATCH v1] RISC-V: Support Zicond extension In-Reply-To: CC: binutils@sourceware.org, philipp.tomsich@vrull.eu, kito.cheng@sifive.com, nelson@rivosinc.com, christoph.muellner@vrull.eu From: Palmer Dabbelt To: jeffreyalaw@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 27 Jun 2023 06:27:25 PDT (-0700), jeffreyalaw@gmail.com wrote: > > > On 6/20/23 22:38, Palmer Dabbelt wrote: >> On Tue, 20 Jun 2023 21:25:12 PDT (-0700), binutils@sourceware.org wrote: >>> >>> >>> On 6/19/23 08:21, Philipp Tomsich wrote: >>>> Given that the 2.41 milestone is approaching and Zicond has passed the >>>> FREEZE milestone (and is even out of public review already), I would >>>> like to move this forward. >>>> Is this OK for trunk?  Should I resubmit with an updated commit message? >>> Given they were acked  with "this is fine to go forward with the spec >>> freezes", I think they can go forward now.  I think you just need to >>> fixup the ChangeLog a bit since it references >>> INSN_CLASS_XVENTANACONDOPS ;-) >> >> Can whomever (IIRC Philipp?) sent the first version just send a v2 with >> the various bits fixed up (ie, no RFC, no "don't merge this" header, and >> the review comments addressed)?  That way there's a chance folks will >> actually look at it. > Seems a bit silly to keep deferring this. I went ahead and fixed up the > ChangeLog entry to reference INSN_CLASS_ZICOND rather than > INSN_CLASS_XVENTANACONDOPS as well as the spec URL and version number > and pushed the result. Works for me -- I just defer to the original poster, but when it's taking months and we're up for a release there's no reason to risk missing. There was also a missing NEWS entry here, I just sent a patch for that and another one we forgot about. > > Jeff