public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, gdb-patches@sourceware.org,
	binutils@sourceware.org, greentime.hu@sifive.com,
	jhb@freebsd.org, greg.savin@sifive.com
Subject: Re: [PATCH v2 2/2] Propagate NT_RISCV_VECTOR from Linux kernel headers to binutils. The value is identical to pre-existing NT_RISCV_CSR but the note names different (NT_RISCV_CSR is "GDB" and NT_RISCV_VECTOR is "CORE")
Date: Fri, 11 Aug 2023 09:43:46 -0700 (PDT)	[thread overview]
Message-ID: <mhng-dc867b93-c0ab-4e7d-9971-5a7d39960f1c@palmer-ri-x1c9> (raw)
In-Reply-To: <87pm3td9ni.fsf@redhat.com>

On Fri, 11 Aug 2023 05:51:45 PDT (-0700), Andrew Burgess wrote:
> Greg Savin via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> ---
>>  include/elf/common.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/elf/common.h b/include/elf/common.h
>> index e7eede23a07..d28f5c6ccf5 100644
>> --- a/include/elf/common.h
>> +++ b/include/elf/common.h
>> @@ -715,6 +715,8 @@
>>  					/*   note name must be "CORE".  */
>>  #define NT_RISCV_CSR    0x900		/* RISC-V Control and Status Registers */
>>  					/*   note name must be "GDB".  */
>> +#define NT_RISCV_VECTOR 0x900		/* RISC-V Vector Registers */
>> +					/*   note name must be "CORE".  */
>
> I'm not a binutils maintainer, but do have an interest from the
> RISC-V/GDB side.
>
> Given the comments you made in an earlier mail, I guess we're going to
> have to restructure some of the core file support in order to handle
> NT_RISCV_CSR and NT_RISCV_VECTOR having the same values.  But that
> should be doable.
>
> No objections to this patch from me.

NT_RISCV_VECTOR isn't in a releasted kernel, so it's not a stable uABI 
yet.  So there's still time to change it.  0I've got a revert on the 
kernel lists, it'd mean we miss 6.5 but we'd just end up in 6.6 which 
isn't so bad.

> Thanks,
> Andrew
>
>
>>  #define NT_SIGINFO	0x53494749	/* Fields of siginfo_t.  */
>>  #define NT_FILE		0x46494c45	/* Description of mapped files.  */
>>
>> --
>> 2.25.1

  reply	other threads:[~2023-08-11 16:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 17:53 [PATCH] Re-map value of NT_RISCV_CSR to not collide with the value of NT_RISCV_VECTOR in Linux kernel header file 'include/uapi/linux/elf.h' Greg Savin
2023-08-10 18:39 ` John Baldwin
2023-08-10 18:56   ` Greg Savin
2023-08-10 20:00     ` John Baldwin
2023-08-10 22:11       ` Greg Savin
2023-08-10 22:11         ` [PATCH v2 1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6 Greg Savin
2023-08-11 12:23           ` Andrew Burgess
2023-08-10 22:11         ` [PATCH v2 2/2] Propagate NT_RISCV_VECTOR from Linux kernel headers to binutils. The value is identical to pre-existing NT_RISCV_CSR but the note names different (NT_RISCV_CSR is "GDB" and NT_RISCV_VECTOR is "CORE") Greg Savin
2023-08-11 12:51           ` Andrew Burgess
2023-08-11 16:43             ` Palmer Dabbelt [this message]
2023-08-12  0:47               ` John Baldwin
2023-08-12  0:50                 ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-dc867b93-c0ab-4e7d-9971-5a7d39960f1c@palmer-ri-x1c9 \
    --to=palmer@dabbelt.com \
    --cc=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=greentime.hu@sifive.com \
    --cc=greg.savin@sifive.com \
    --cc=jhb@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).