From: Andreas Schwab <schwab@suse.de>
To: Nelson Chu <nelson@rivosinc.com>
Cc: binutils@sourceware.org, kito.cheng@sifive.com,
jim.wilson.gcc@gmail.com, palmer@rivosinc.com,
andrew@sifive.com, nelson.rivosinc.com@NelsondeMBP.localdomain
Subject: Re: [PATCH] RISC-V: Don't generate branch/jump relocation if symbol is local when no-relax.
Date: Tue, 30 Jan 2024 11:00:58 +0100 [thread overview]
Message-ID: <mvm4jev9m3p.fsf@suse.de> (raw)
In-Reply-To: <20240129131741.48824-1-nelson@rivosinc.com> (Nelson Chu's message of "Mon, 29 Jan 2024 21:17:41 +0800")
On Jan 29 2024, Nelson Chu wrote:
> Refer to commit, dff565fcca8137954d6ad571ef39f6aec5c0429c. Theoretically,
> assembler don't need to generate the pc-relative relocation and the refered
> local .L symbol when relaxation is disabled. The above commit improved the
> pcrel_hi/pcrel_lo relocations, and this commit improves branch and jump
> relocations.
>
> Passed the gcc/binutils regressions of riscv-gnu-toolchain.
>
> gas/
> * config/tc-riscv.c (md_apply_fix): Raise fixP->fx_done for all
> branch and jump relocations when -mno-relax.
Is this related to PR30591?
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2024-01-30 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 13:17 Nelson Chu
2024-01-30 10:00 ` Andreas Schwab [this message]
2024-01-30 11:55 ` Nelson Chu
2024-02-19 14:34 ` Andreas Schwab
2024-02-20 0:19 ` Nelson Chu
2024-02-21 7:04 ` Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm4jev9m3p.fsf@suse.de \
--to=schwab@suse.de \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=nelson.rivosinc.com@NelsondeMBP.localdomain \
--cc=nelson@rivosinc.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).