From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id D64833858D33 for ; Tue, 31 Jan 2023 11:55:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D64833858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1A11D205F3 for ; Tue, 31 Jan 2023 11:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675166113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vtjS1gVgVK2Dn0QoHm1eEvaLxnZ7JBq/Dyr4jlSHIL0=; b=xqmg7ogN/U0tIFPr7Zl6TrPXRZOIliNs81rRwNQby3OP9ztF3rVUDFql7TfsSIJfYYhS7w GKwL0gEWwxlD8jUJCxS9JiG/iDl1DuaN0Ah3CZiqjTtS7dWrxm+mZaV2U8tspqCTfDFxNI LelvexHCOQD2Bs5UEsngvGWVJxXa0RI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675166113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vtjS1gVgVK2Dn0QoHm1eEvaLxnZ7JBq/Dyr4jlSHIL0=; b=E3l5h/66Ae4JYls0HS8Ufkvo7AaqqAgvuSbF706/+GawT/KdLK+suCzYyx453QrSJVbz2E 6X7HrqJgMrB2uECg== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 10A432C143; Tue, 31 Jan 2023 11:55:13 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id CA061440D4E; Tue, 31 Jan 2023 12:55:12 +0100 (CET) From: Andreas Schwab To: Tom de Vries via Binutils Cc: Tom de Vries Subject: Re: [PATCH] [gas] Emit v2 .debug_line for -gdwarf-2 References: <20230131114257.4585-1-tdevries@suse.de> X-Yow: Do I hear th' SPINNING of various WHIRRING, ROUND, and WARM WHIRLOMATICS?! Date: Tue, 31 Jan 2023 12:55:12 +0100 In-Reply-To: <20230131114257.4585-1-tdevries@suse.de> (Tom de Vries via Binutils's message of "Tue, 31 Jan 2023 12:42:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 31 2023, Tom de Vries via Binutils wrote: > Fix this by emitting a v3 .debug_line contribution instead. s/v3/v2/? > diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c > index c7d9e8ef72f..e6c411426af 100644 > --- a/gas/dwarf2dbg.c > +++ b/gas/dwarf2dbg.c > @@ -88,7 +88,7 @@ > > /* This implementation outputs version 3 .debug_line information. */ > #ifndef DWARF2_LINE_VERSION > -#define DWARF2_LINE_VERSION (dwarf_level > 3 ? dwarf_level : 3) > +#define DWARF2_LINE_VERSION dwarf_level Seems like the comment is no longer accurate. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."