From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id A529C3858420 for ; Tue, 9 Jul 2024 09:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A529C3858420 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A529C3858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720517449; cv=none; b=RIoxtdMTH8TgzVHHrL06z7kX0r2uIpkeu2UFZtyrI7h+hRYKUjSEpfWlhT5OYhEBa5QJ8jhyE016ghcaVVHh/r0gdDo3UbyvHvVjc/cjGNUAFGNvww2qKA4FovQagpxv/uE6pI1wEhGA+TK/IftkkHPu6YOLKq6ge6NPeNaSoxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720517449; c=relaxed/simple; bh=lf2xNHDGmLFnetuNzKAKHO8kmzfKGVjszy9h/v8S6Jc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=lQnv/4v35DY5x3EEq4/dROlDpI2ZwmFm7NaqCWgYXKyfO8/HEwW/FYhTsPvSX8Ih/pXzCwwr5MH9V6K2OeZaQFCEAIfvPpYbHTdTDZ6lu4WSbiaxdAuS1r1yWeCU+8TbPSfsWvyzn4PSagAoC76tZ5swrvrklxSLG4pEvaN7Zj4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out2.suse.de (Postfix) with ESMTP id 8E6A61F7A9; Tue, 9 Jul 2024 09:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720517446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WezS2M/kJX9GbH5TIVDtmgsLH+LQt9h2ao0Aecgws3I=; b=RYinzRi+sGloi4H/0QMQ5WItfQpxMv2hd9YNmslucOee4E4TuPfhzmY4VnQgwg+SLSon2z zNLWbqVa1GmnhbMueapei5fhBziD1tSyfelecmmpgIbjYq3O9WzusLMwxErHo0SXjAzmYv T9I7MBmSkeCUrpXN/rBDscvnDFO635o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720517446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WezS2M/kJX9GbH5TIVDtmgsLH+LQt9h2ao0Aecgws3I=; b=8TFHmJfr6+A3+Izhud9sGg0ZSN21JJ8RqrrdOqatGbBrtdruEDX3fYFEJjyV8ztpTuUbCa 5XfAzRDIniGcbAAQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720517446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WezS2M/kJX9GbH5TIVDtmgsLH+LQt9h2ao0Aecgws3I=; b=RYinzRi+sGloi4H/0QMQ5WItfQpxMv2hd9YNmslucOee4E4TuPfhzmY4VnQgwg+SLSon2z zNLWbqVa1GmnhbMueapei5fhBziD1tSyfelecmmpgIbjYq3O9WzusLMwxErHo0SXjAzmYv T9I7MBmSkeCUrpXN/rBDscvnDFO635o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720517446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WezS2M/kJX9GbH5TIVDtmgsLH+LQt9h2ao0Aecgws3I=; b=8TFHmJfr6+A3+Izhud9sGg0ZSN21JJ8RqrrdOqatGbBrtdruEDX3fYFEJjyV8ztpTuUbCa 5XfAzRDIniGcbAAQ== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id 8023A4AAD89; Tue, 9 Jul 2024 11:30:46 +0200 (CEST) From: Andreas Schwab To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] elf: Add glibc version dependency only if needed In-Reply-To: <20240709084854.3446407-1-hjl.tools@gmail.com> (H. J. Lu's message of "Tue, 9 Jul 2024 01:48:54 -0700") References: <20240709084854.3446407-1-hjl.tools@gmail.com> X-Yow: I feel partially hydrogenated! Date: Tue, 09 Jul 2024 11:30:46 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.08 / 50.00]; BAYES_HAM(-2.89)[99.52%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.971]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-Spam-Score: -4.08 X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jul 09 2024, H.J. Lu wrote: > There is no need to add a needed glibc version if the glibc base version > includes the needed glibc version. > > PR ld/31966 > * elflink.c (elf_link_add_glibc_verneed): Add glibc_minor_base. > Skip if the glibc base version includes the needed glibc version. > (_bfd_elf_link_add_glibc_version_dependency): Initialize > glibc_minor_base to INT_MAX and pass it to > elf_link_add_glibc_verneed. Why was this not handled by a special version symbol like GLIBC_ABI_DT_RELR? -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."