From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 2D19A3857C66 for ; Wed, 31 Jan 2024 09:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D19A3857C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D19A3857C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706692462; cv=none; b=flwUExWdDTFRibII9S/Rlcb5rQz3qD02QJWmg4tXpAFYvk38fEqPaScPmumLxkXHUx/owXdJcKyw52NDYW6qnxMeGkDbEmuUyF5LuBmvQC9PusVctIYegknZuQaJmunE+a/0U3Td20bZGzfxi89+hfHAUScSu6B/gzvWDhL5Pns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706692462; c=relaxed/simple; bh=H6p3W/ydh9MfDvG/rT+AlgKw4Vgk6c5UN+UKdMHh6OE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=U1XhVLXIq4y4Em4tnU7lG/Ur07miEMV4MJhrMjNh+HIkG0Qm2EcaECFO777T0RV/xo8Y0gnubNiGJJI1QmYmjhLvJowOKIZh1DXmH93deaU201AWZ+baZ6MzI+yLnv+4zUHXv+8GPnFD4Efa83Di6IcJ5YaFPr1y2B1+MOaGPI4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out2.suse.de (Postfix) with ESMTP id 336241FB6C; Wed, 31 Jan 2024 09:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706692460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=or7+WawCh93FR3xZeivnk0VvsG9j1Fo7km5c8klCDsk=; b=XEQU+g0DmcCpLKdjbGaqB42UHLLRq+UIE+Bk34p9tb7fHNJ3SPccD+m/pFADHOirBgVDo6 Fj5D2x9KHFbGAWtdROwgZEAQOEdaxz+5yza5IbXPvBMpIXf+lu8Z1fj/OClj4KW7QKiPfU +++7cUHRr+VHnJwWLmXiQVVAcnOrOvI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706692460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=or7+WawCh93FR3xZeivnk0VvsG9j1Fo7km5c8klCDsk=; b=QIRm2JCLdLvDMkfc2AnCtEphZ0YhnEuLw6IJPg9l7QyHGFqS/jZOP8a53SfNajxfWPqIrf vavlL+2S1Bn3olBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706692460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=or7+WawCh93FR3xZeivnk0VvsG9j1Fo7km5c8klCDsk=; b=XEQU+g0DmcCpLKdjbGaqB42UHLLRq+UIE+Bk34p9tb7fHNJ3SPccD+m/pFADHOirBgVDo6 Fj5D2x9KHFbGAWtdROwgZEAQOEdaxz+5yza5IbXPvBMpIXf+lu8Z1fj/OClj4KW7QKiPfU +++7cUHRr+VHnJwWLmXiQVVAcnOrOvI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706692460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=or7+WawCh93FR3xZeivnk0VvsG9j1Fo7km5c8klCDsk=; b=QIRm2JCLdLvDMkfc2AnCtEphZ0YhnEuLw6IJPg9l7QyHGFqS/jZOP8a53SfNajxfWPqIrf vavlL+2S1Bn3olBw== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id 0B9D44A04E5; Wed, 31 Jan 2024 10:14:20 +0100 (CET) From: Andreas Schwab To: Joseph Faulls Cc: "binutils@sourceware.org" , "nelson@rivosinc.com" , "palmer@rivosinc.com" Subject: Re: [PATCH] bfd: check for truncation with R_RISCV_32 relocations In-Reply-To: (Joseph Faulls's message of "Tue, 30 Jan 2024 18:21:25 +0000") References: X-Yow: I'm definitely not in Omaha! Date: Wed, 31 Jan 2024 10:14:20 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.95 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.85)[85.41%] X-Spam-Level: X-Spam-Score: -0.95 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 30 2024, Joseph Faulls wrote: > diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c > index 8b27e3b8d6a..975b40e5f53 100644 > --- a/bfd/elfnn-riscv.c > +++ b/bfd/elfnn-riscv.c > @@ -1865,6 +1865,9 @@ perform_relocation (const reloc_howto_type *howto, > } > > case R_RISCV_32: > + if (value & ~howto->dst_mask) > + return bfd_reloc_overflow; > + break; The overflow check belongs to the howto table. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."