From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 37A253858CDA for ; Tue, 30 Jan 2024 14:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37A253858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37A253858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706624858; cv=none; b=VXBcINjMs62Fdn3NYgBfQODGJolII+z4I9SSsb83BpaFFJgqQF+h5FRbJ4MMzxauDDyCXewh/YXbvWy5oa9d8CAh+ZkQEmBUILXwbwNCLMv/N1YEmvvBospSH2thq/PrCYf42B/NjCd47wdG5aEMeYFPcaWG+B1bSAPKeA8z+oc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706624858; c=relaxed/simple; bh=vMTYchIR0ock+PpTKhcU2CwJgTntKFH9t/yybz3oox4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=G8xjP9BgFODdVtgyTQIVeZTl4dZECsK7ZE9mhPrxSgMTykPyzHGTkw9P78cUXovEF5UlcIXuyAtMImpOUBA5GXoMQLjS8dtJB347Gh6cwdioXZToEq+gjakqIBPTusEyKkbtgQ5fqCl23KR71SwfvPPpelssJJxgNMuHiMR+iXk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id 4A91421F96; Tue, 30 Jan 2024 14:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706624855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wlwuyo5SKGly/bQ0uaAkOzt5Eyral+uh6fK3Vn3sxBE=; b=FefcQ1VOS89LFBg/p2PUn1lmLezC+vroILSBG2ZdisFlLsgJtlw0elHpXelzNUtd3iQJQD 17fb8p6l3AcXZFV8CLeIq4Js/TGAWgMPALv9kKSddfGW4vyMaP/iDi8hDH8iNpYYMThjb+ X7lRtaTgD2aaTxInf6OBwFfdW3w8Hb8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706624855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wlwuyo5SKGly/bQ0uaAkOzt5Eyral+uh6fK3Vn3sxBE=; b=k/3xAmTAdokRw3ohREE3flNGFdPIy1TsB5n+J/TeHX6awn75cELoMjN/DC3XH28S/v3aPC WkOEO16HKnZB5tDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706624855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wlwuyo5SKGly/bQ0uaAkOzt5Eyral+uh6fK3Vn3sxBE=; b=FefcQ1VOS89LFBg/p2PUn1lmLezC+vroILSBG2ZdisFlLsgJtlw0elHpXelzNUtd3iQJQD 17fb8p6l3AcXZFV8CLeIq4Js/TGAWgMPALv9kKSddfGW4vyMaP/iDi8hDH8iNpYYMThjb+ X7lRtaTgD2aaTxInf6OBwFfdW3w8Hb8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706624855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wlwuyo5SKGly/bQ0uaAkOzt5Eyral+uh6fK3Vn3sxBE=; b=k/3xAmTAdokRw3ohREE3flNGFdPIy1TsB5n+J/TeHX6awn75cELoMjN/DC3XH28S/v3aPC WkOEO16HKnZB5tDQ== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id F0DC04A04E5; Tue, 30 Jan 2024 15:27:34 +0100 (CET) From: Andreas Schwab To: Nick Alcock Cc: binutils@sourceware.org, torbjorn.svensson@foss.st.com, yvan.roux@foss.st.com Subject: Re: [PATCH] libctf: check for problems with error returns In-Reply-To: <87sf2evr35.fsf@esperi.org.uk> (Nick Alcock's message of "Tue, 30 Jan 2024 14:22:22 +0000") References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> <87sf2evr35.fsf@esperi.org.uk> X-Yow: I'm in LOVE with DON KNOTTS!! Date: Tue, 30 Jan 2024 15:27:34 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -3.10 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 30 2024, Nick Alcock wrote: > diff --git a/libctf/testsuite/libctf-writable/libctf-errors.c b/libctf/testsuite/libctf-writable/libctf-errors.c > index 71f8268cfad..2790b608396 100644 > --- a/libctf/testsuite/libctf-writable/libctf-errors.c > +++ b/libctf/testsuite/libctf-writable/libctf-errors.c > @@ -12,7 +12,7 @@ main (int argc, char *argv[]) > ctf_dict_t *fp; > ctf_next_t *i = NULL; > size_t boom = 0; > - ctf_id_t itype, stype; > + ctf_id_t itype = 0, stype = 0; > ctf_encoding_t encoding = {0}; > ctf_membinfo_t mi; > ssize_t ret; This silences the warnings and all dependent tests pass. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."