From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=EPMt=4D=suse.de=schwab@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 30401385B51C
	for <binutils@sourceware.org>; Mon,  5 Dec 2022 09:47:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30401385B51C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out1.suse.de (Postfix) with ESMTP id 5306521B84;
	Mon,  5 Dec 2022 09:47:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1670233650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lIEJAAxCXIr/DnCClX8HxaKnT0u25DbqjNNVTu/PXiA=;
	b=VgMxhPWqHPytxfsmmthLco2IGzg15B0NgoqjsXZoNjunCPQ4B9RFrI1bWS73VbPKzEdQq/
	U9GV/rZEJwmsdfbVF4BHrK/RxxG1LTxt9ckxPpuUlTAcSnlWOvMxtqJMDDNezhfMOhqIyX
	c81Uw71OZqBsSSYIyeg2OVHOgQAEFKY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1670233650;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=lIEJAAxCXIr/DnCClX8HxaKnT0u25DbqjNNVTu/PXiA=;
	b=3EcOtSB8WwNlvSnpVkdFO6sGbQPakjW7zYTa4SkyGZoASeQPxk3JqVqrYxRkDQ29ShKndw
	JZZrtiyKT6FJyUDw==
Received: from hawking.suse.de (unknown [10.168.4.11])
	by relay2.suse.de (Postfix) with ESMTP id 4A2812C142;
	Mon,  5 Dec 2022 09:47:30 +0000 (UTC)
Received: by hawking.suse.de (Postfix, from userid 17005)
	id 305714409A6; Mon,  5 Dec 2022 10:47:30 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: mengqinggang <mengqinggang@loongson.cn>
Cc: binutils@sourceware.org,  xuchenghua@loongson.cn,
  liuzhensong@loongson.cn,  chenglulu@loongson.cn,  xry111@xry111.site,
  i.swmail@xen0n.name,  maskray@google.com
Subject: Re: [PATCH v1 5/6] LoongArch: gas: Add support for linker relaxation.
References: <20221205080453.1352069-1-mengqinggang@loongson.cn>
	<20221205080453.1352069-6-mengqinggang@loongson.cn>
X-Yow: I'm having an emotional outburst!!
Date: Mon, 05 Dec 2022 10:47:30 +0100
In-Reply-To: <20221205080453.1352069-6-mengqinggang@loongson.cn>
	(mengqinggang@loongson.cn's message of "Mon, 5 Dec 2022 16:04:52
	+0800")
Message-ID: <mvmzgc25gi5.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Dez 05 2022, mengqinggang wrote:

> @@ -1258,19 +1406,7 @@ int
>  md_estimate_size_before_relax (fragS *fragp ATTRIBUTE_UNUSED,
>  			       asection *segtype ATTRIBUTE_UNUSED)
>  {
> -  return 0;
> -}
> -
> -int
> -loongarch_fix_adjustable (fixS *fix)
> -{
> -  /* Prevent all adjustments to global symbols.  */
> -  if (S_IS_EXTERNAL (fix->fx_addsy)
> -      || S_IS_WEAK (fix->fx_addsy)
> -      || S_FORCE_RELOC (fix->fx_addsy, true))
> -    return 0;
> -
> -  return 1;
> +  return (fragp->fr_var = 4);

Please don't use an assignment inside an expression.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."