From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 10C283858C5F for ; Mon, 22 Apr 2024 05:50:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10C283858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10C283858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713765044; cv=none; b=ZJYOvIx/0zkT/PT9Lru+vm37uhMMSJB7cL5LXPky/Tk+rVdrK6ZjQQJXmFbzvmrOhGuh2fS4T5YZVtbMSNE2hqLszSDEnNhTjgMZMXEHpq2ikb7qAYt/qBCPTMqxf31PWPWiIBAbp3ML+gKtA7Z0eH9T3NHZVJGl4PBUybvbVms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713765044; c=relaxed/simple; bh=NS6h9WA4aSzPwws53mnAd74fpf1dQT2N5O+3N61a/y8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=x3Xe+YhCxi4R3H0UVaGyN5COeorVGJootkYXY8+qaC6XLRoNHPggvYsKRSXrw8VC9dSFKKE9EZ4gXjhw5wYAR3npqlWoqv5E0SzhWqKz6rQ+3b/dE/kqJTaomSqQmeZ2/SIztj7FB9siMcAv0kbRFZGDIOaBf5lt9XbKvvd1ZrA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from linux-libre.fsfla.org ([2001:470:142:5::54] helo=free.home) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rymZd-0005h8-Eb; Mon, 22 Apr 2024 01:50:42 -0400 Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43M5oSnq013964 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Apr 2024 02:50:29 -0300 From: Alexandre Oliva To: "H.J. Lu" Cc: binutils@sourceware.org, hainque@adacore.com Subject: Re: [PATCH] elf: Strip unreferenced weak undefined symbols Organization: Free thinker, not speaking for the GNU Project References: <20240418122856.190234-1-hjl.tools@gmail.com> Date: Mon, 22 Apr 2024 02:50:28 -0300 In-Reply-To: <20240418122856.190234-1-hjl.tools@gmail.com> (H. J. Lu's message of "Thu, 18 Apr 2024 05:28:56 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks again for the patch. Olivier pointed out that a comment you moved had a duplicate word, and suggested removing it. Ok to install? From: Olivier Hainque Date: Mon, 22 Apr 2024 05:30:38 +0000 Remove duplicate word. for bfd/ChangeLog PR ld/31652 * elflink.c (_bfd_elf_link_output_relocs): Drop duplicate word. --- bfd/elf-vxworks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/elf-vxworks.c b/bfd/elf-vxworks.c index 36e5540f9c04..5d91913f097f 100644 --- a/bfd/elf-vxworks.c +++ b/bfd/elf-vxworks.c @@ -186,7 +186,7 @@ elf_vxworks_emit_relocs (bfd *output_bfd, library. We are creating a definition in the output file but it does not come from any of our normal (.o) files. ie. a PLT stub. Normally this would be a - relocation against against SHN_UNDEF with the VMA of + relocation against SHN_UNDEF with the VMA of the PLT stub. This upsets the VxWorks loader. Convert it to a section-relative relocation. This gets some other symbols (for instance .dynbss), but -- 2.25.1 -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Think Assange & Stallman. The empires strike back