Re: [PATCH] adjust NetWare support

Re: [PATCH] adjust NetWare support

[Jan Beulich]

> 1. What is happening to the PPC and ALPHA Netware targets ? Are they
being abandoned ?

They never really existed. Years ago there was an effort started to get
them to work, but that was never finished (nor any other of the plans
that targeted architectures other than x86).

Jan

Re: [PATCH] adjust NetWare support

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Nick Clifton <nickc@redhat.com> writes:

>    2. So you have an FSF binutils copyright assignment ?  I could not
>    find one, and it would be very helpful if you did have one.  I have
>    treated this patch as being "obvious" and so not needing an
>    assignment, but other patches may not qualify like that.

I was in contact with the copyright clerk this week since I couldn't
find the assignment either: A copyright assignment has been made but
was rejected on a formality, and it will be signed again.  This should
be solved soon,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] adjust NetWare support

[Nick Clifton]

Hi Jan,

> 2004-06-03 Jan Beulich <jbeulich@novell.com>
> 
> 	* gas/config/tc-i386.c: Deal with LEX_QM the same way as with
> LEX_AT.
> 	* gas/config/te-netware.h: New file.
> 	* gas/configure.in: Eliminate ill NetWare targets. Make generic
> 	NetWare target use proper emulation.
> 	* gas/Makefile.am: Eliminate reference to ill te-ppcnw.h, add
> reference
> 	to new te-netware.h.

Approved and applied.

Thanks very much for submitting this patch.  I am sorry that it took me 
so long to get around to reviewing it.

Two questions:

   1. What is happening to the PPC and ALPHA Netware targets ?  Are they 
being abandoned ?

   2. So you have an FSF binutils copyright assignment ?  I could not 
find one, and it would be very helpful if you did have one.  I have 
treated this patch as being "obvious" and so not needing an assignment, 
but other patches may not qualify like that.

Cheers
   Nick

[PATCH] adjust NetWare support

[Jan Beulich]

Built as cross i686-novell-netware on i686-pc-linux-gnu. Testsuite run
with no unexpected failures.

2004-06-03 Jan Beulich <jbeulich@novell.com>

	* gas/config/tc-i386.c: Deal with LEX_QM the same way as with
LEX_AT.
	* gas/config/te-netware.h: New file.
	* gas/configure.in: Eliminate ill NetWare targets. Make generic
	NetWare target use proper emulation.
	* gas/Makefile.am: Eliminate reference to ill te-ppcnw.h, add
reference
	to new te-netware.h.

---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/config/tc-i386.c	2004-04-20
14:17:14.000000000 +0200
+++ 2004-06-03.09.12/gas/config/tc-i386.c	2004-06-03
10:22:33.663347560 +0200
@@ -182,15 +182,19 @@
 
 /* List of chars besides those in app.c:symbol_chars that can start
an
    operand.  Used to prevent the scrubber eating vital white-space. 
*/
+const char extra_symbol_chars[] = "*%-(["
 #ifdef LEX_AT
-const char extra_symbol_chars[] = "*%-(@[";
-#else
-const char extra_symbol_chars[] = "*%-([";
+	"@"
+#endif
+#ifdef LEX_QM
+	"?"
 #endif
+	;
 
 #if (defined (TE_I386AIX)				\
      || ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF))	\
 	 && !defined (TE_LINUX)				\
+	 && !defined (TE_NETWARE)			\
 	 && !defined (TE_FreeBSD)			\
 	 && !defined (TE_NetBSD)))
 /* This array holds the chars that always start a comment.  If the
@@ -972,6 +979,10 @@
 #ifdef LEX_AT
     identifier_chars['@'] = '@';
 #endif
+#ifdef LEX_QM
+    identifier_chars['?'] = '?';
+    operand_chars['?'] = '?';
+#endif
     digit_chars['-'] = '-';
     identifier_chars['_'] = '_';
     identifier_chars['.'] = '.';
---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/config/te-netware.h	1970-01-01
01:00:00.000000000 +0100
+++ 2004-06-03.09.12/gas/config/te-netware.h	2004-04-01
08:52:42.000000000 +0200
@@ -0,0 +1,8 @@
+#define TE_NETWARE
+#define LOCAL_LABELS_FB 1
+
+#define LEX_AT (LEX_NAME|LEX_BEGIN_NAME) /* can have @'s inside labels
*/
+#define LEX_PCT (LEX_NAME|LEX_BEGIN_NAME) /* can have %'s inside
labels */
+#define LEX_QM (LEX_NAME|LEX_BEGIN_NAME) /* can have ?'s inside labels
*/
+
+#include "obj-format.h"
---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/configure	2004-05-17
21:50:15.000000000 +0200
+++ 2004-06-03.09.12/gas/configure	2004-06-03 10:15:02.563925096
+0200
@@ -4229,7 +4229,6 @@
       a29k-*-vxworks*)			fmt=coff ;;
 
       alpha*-*-*vms*)			fmt=evax ;;
-      alpha*-*-netware*)		fmt=ecoff ;;
       alpha*-*-osf*)			fmt=ecoff ;;
       alpha*-*-linuxecoff*)		fmt=ecoff ;;
       alpha*-*-linux-gnu*)		fmt=elf em=linux ;;
@@ -4490,7 +4489,6 @@
 	    fi ;;
       ppc-*-rtems*)			fmt=elf ;;
       ppc-*-macos*)			fmt=coff em=macos ;;
-      ppc-*-netware*)			fmt=elf em=ppcnw ;;
       ppc-*-nto*)			fmt=elf ;;
       ppc-*-kaos*)			fmt=elf ;;
       ppc-*-lynxos*)			fmt=elf em=lynx bfd_gas=yes ;;
@@ -4579,7 +4577,7 @@
       *-*-elf | *-*-sysv4* | *-*-solaris*) fmt=elf dev=yes ;;
       *-*-aros*)			fmt=elf em=linux bfd_gas=yes ;;
       *-*-vxworks | *-*-windiss)	fmt=elf ;;
-      *-*-netware)			fmt=elf ;;
+      *-*-netware)			fmt=elf em=netware ;;
     esac
 
     if test ${this_target} = $target ; then
---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/configure.in	2004-05-17
21:50:16.000000000 +0200
+++ 2004-06-03.09.12/gas/configure.in	2004-06-03 10:14:50.814711248
+0200
@@ -190,7 +190,6 @@
       a29k-*-vxworks*)			fmt=coff ;;
 
       alpha*-*-*vms*)			fmt=evax ;;
-      alpha*-*-netware*)		fmt=ecoff ;;
       alpha*-*-osf*)			fmt=ecoff ;;
       alpha*-*-linuxecoff*)		fmt=ecoff ;;
       alpha*-*-linux-gnu*)		fmt=elf em=linux ;;
@@ -434,7 +433,6 @@
 	    fi ;;
       ppc-*-rtems*)			fmt=elf ;;
       ppc-*-macos*)			fmt=coff em=macos ;;
-      ppc-*-netware*)			fmt=elf em=ppcnw ;;
       ppc-*-nto*)			fmt=elf ;;
       ppc-*-kaos*)			fmt=elf ;;
       ppc-*-lynxos*)			fmt=elf em=lynx bfd_gas=yes ;;
@@ -523,7 +521,7 @@
       *-*-elf | *-*-sysv4* | *-*-solaris*) fmt=elf dev=yes ;;
       *-*-aros*)			fmt=elf em=linux bfd_gas=yes ;;
       *-*-vxworks | *-*-windiss)	fmt=elf ;;
-      *-*-netware)			fmt=elf ;;
+      *-*-netware)			fmt=elf em=netware ;;
     esac
 
     if test ${this_target} = $target ; then
---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/Makefile.am	2004-06-02
16:36:18.000000000 +0200
+++ 2004-06-03.09.12/gas/Makefile.am	2004-06-03 10:12:49.675127264
+0200
@@ -391,9 +391,9 @@
 	config/te-macos.h \
 	config/te-nbsd.h \
 	config/te-nbsd532.h \
+	config/te-netware.h \
 	config/te-pc532mach.h \
 	config/te-pe.h \
-	config/te-ppcnw.h \
 	config/te-psos.h \
 	config/te-riscix.h \
 	config/te-sparcaout.h \
---
/home/jbeulich/src/binutils/mainline/2004-06-03.09.12/gas/Makefile.in	2004-06-02
16:36:18.000000000 +0200
+++ 2004-06-03.09.12/gas/Makefile.in	2004-06-03 10:12:49.684125896
+0200
@@ -618,9 +618,9 @@
 	config/te-macos.h \
 	config/te-nbsd.h \
 	config/te-nbsd532.h \
+	config/te-netware.h \
 	config/te-pc532mach.h \
 	config/te-pe.h \
-	config/te-ppcnw.h \
 	config/te-psos.h \
 	config/te-riscix.h \
 	config/te-sparcaout.h \