public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: <wilson@specifixinc.com>
Cc: <binutils@sources.redhat.com>
Subject: Re: [PATCH] ia64 application register handling
Date: Thu, 27 Jan 2005 08:41:00 -0000	[thread overview]
Message-ID: <s1f8a908.044@emea1-mh.id2.novell.com> (raw)

>In the emit_one_bundle hunk, inside the #if 0, you accidentally lost a
>comment.  However, this code is long obsolete.  An idesc no longer has
a
>next field; this was dropped even before the code was contributed to
the
>FSF.  I suspect this happened when Bob Manson wrote the ia64-gen.c
>program.  So we should just drop this #if 0 code instead of putting
the
>comment back.

Actually, the comment wasn't lost accidently, but intentionally. But
maybe it should have been modified slightly by adding the word 'other'.
Since this was in an #if 0 block, thus counting as comment, I took the
freedom to slightly change this to

 #if 0
-	  know (!idesc->next);	/* no resolved dynamic ops have
collisions */
+	  else
+	    /* no other resolved dynamic ops have collisions */
+	    know (!get_next_opcode (idesc));
 #endif

Jan

             reply	other threads:[~2005-01-27  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-27  8:41 Jan Beulich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-01-25  7:37 Jan Beulich
2005-01-24  9:51 Jan Beulich
2005-01-24 23:01 ` Hans-Peter Nilsson
2005-01-27  1:52 ` James E Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s1f8a908.044@emea1-mh.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=binutils@sources.redhat.com \
    --cc=wilson@specifixinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).