From: "Jan Beulich" <JBeulich@novell.com>
To: <amodra@bigpond.net.au>
Cc: <binutils@sources.redhat.com>
Subject: Re: [PATCH] i386: cr8 handling
Date: Tue, 01 Mar 2005 14:19:00 -0000 [thread overview]
Message-ID: <s22479f8.048@emea1-mh.id2.novell.com> (raw)
>> @@ -5040,6 +5047,7 @@ parse_register (reg_string, end_op)
>>
>> if (r != NULL
>> && ((r->reg_flags & (RegRex64 | RegRex)) | (r->reg_type &
Reg64)) != 0
>> + && r->reg_type != Control
>
>I think this should be
> && (r->reg_type != Control || (cpu_arch_flags & CpuSledgehammer)
!= 0)
>
>ie. Only enable cr8..cr15 if given ".arch sledgehammer".
I thought about that, too. But SledgeHammer isn't really the right
thing here, because only newer (future) processors are going to support
this. The granularity of these CPU-level things isn't right these days
anymore; you'd have to have a way to specify individual features...
Also, I'd think it should be
&& (r->reg_type != Control || !(cpu_arch_flags &
CpuSledgehammer))
Please let me know if you indeed want me to add this additional check.
>Otherwise the patch looks OK to apply. Of course, you'll need to
adjust
>your testcases to supply .arch.
Why? CpuUnknownFlags contains CpuSledgehammer, so it should be enabled
by default.
Thanks, Jan
next reply other threads:[~2005-03-01 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-01 14:19 Jan Beulich [this message]
2005-03-01 22:07 ` Alan Modra
-- strict thread matches above, loose matches on Subject: below --
2005-03-01 8:52 Jan Beulich
2005-03-01 12:06 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s22479f8.048@emea1-mh.id2.novell.com \
--to=jbeulich@novell.com \
--cc=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).