From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12559 invoked by alias); 18 Apr 2005 07:57:14 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 12496 invoked from network); 18 Apr 2005 07:57:08 -0000 Received: from unknown (HELO emea1-mh.id2.novell.com) (195.33.99.129) by sourceware.org with SMTP; 18 Apr 2005 07:57:08 -0000 Received: from EMEA1-MTA by emea1-mh.id2.novell.com with Novell_GroupWise; Mon, 18 Apr 2005 08:57:07 +0200 Message-Id: Date: Mon, 18 Apr 2005 07:57:00 -0000 From: "Jan Beulich" To: , Cc: ,, Subject: Re: [PATCH] ELF: make .struct interact with .previous Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part6E4D424F.3__=" X-SW-Source: 2005-04/txt/msg00467.txt.bz2 This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part6E4D424F.3__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-length: 1328 >>> Alan Modra 18.04.05 01:34:05 >>> >The struct test is using a .short, which looks like a data allocation >pseudo-op to me. If .short should have different alignment when you >happen to use it in the absolute section, then md_cons_align should >reflect that fact. I agree to this; therefore I'd suggest the below adjustment to the test. Jan gas/testsuite/ 2005-04-15 Jan Beulich * gas/elf/struct.s: Adjust to not get into alignment issues. * gas/elf/struct.d: Adjust for the above and the test's name. --- cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.d.0 2= 005-04-12 11:48:51.000000000 +0200 +++ cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.d 200= 5-04-18 09:54:43.846300704 +0200 @@ -1,10 +1,10 @@ #nm: --extern-only -#name: struct +#name: ELF struct =20 # Test the .struct pseudo-op. =20 0+0 D l1 0+4 D l2 -0+1 A w1 -0+3 A w2 -0+5 A w3 +0+2 A w1 +0+4 A w2 +0+6 A w3 --- cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.s.0 2= 005-04-12 11:45:06.000000000 +0200 +++ cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.s 200= 5-04-18 09:48:26.401681008 +0200 @@ -1,7 +1,7 @@ .globl w1, w2, w3, l1, l2 .data l1: .long 0 - .struct 1 + .struct 2 w1: .short 0 w2: .short 0 w3: .short 0 --=__Part6E4D424F.3__= Content-Type: text/plain; name="binutils-mainline-elf-struct-2.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="binutils-mainline-elf-struct-2.patch" Content-length: 1022 I agree to this; therefore I'd suggest the below adjustment to the test. Jan gas/testsuite/ 2005-04-15 Jan Beulich * gas/elf/struct.s: Adjust to not get into alignment issues. * gas/elf/struct.d: Adjust for the above and the test's name. --- cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.d.0 2005-04-12 11:48:51.000000000 +0200 +++ cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.d 2005-04-18 09:54:43.846300704 +0200 @@ -1,10 +1,10 @@ #nm: --extern-only -#name: struct +#name: ELF struct # Test the .struct pseudo-op. 0+0 D l1 0+4 D l2 -0+1 A w1 -0+3 A w2 -0+5 A w3 +0+2 A w1 +0+4 A w2 +0+6 A w3 --- cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.s.0 2005-04-12 11:45:06.000000000 +0200 +++ cpp/binutils/mainline-cvs/2005-04-11/gas/testsuite/gas/elf/struct.s 2005-04-18 09:48:26.401681008 +0200 @@ -1,7 +1,7 @@ .globl w1, w2, w3, l1, l2 .data l1: .long 0 - .struct 1 + .struct 2 w1: .short 0 w2: .short 0 w3: .short 0 --=__Part6E4D424F.3__=--