From: Ian Lance Taylor <ian@zembu.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Include alloca.h for bfd
Date: Tue, 21 Aug 2001 14:56:00 -0000 [thread overview]
Message-ID: <si4rr113q3.fsf@daffy.airs.com> (raw)
In-Reply-To: <20010821234604.J30301@rembrandt.csv.ica.uni-stuttgart.de>
Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
> Ian Lance Taylor wrote:
> > Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
> >
> > > this checks for inclusion of alloca.h, which is required on IRIX6.5
> > > to compile e.g. linker.c.
> >
> > This patch is incorrect. Any declaration of alloca or inclusions of
> > alloca.h must be done as in gas/as.h.
>
> Uh, that's a really ugly piece of code.
It's a really ugly problem.
Your suggested patch would have broken the build on a few systems
which have alloca.h when using gcc to compile.
> > In the past I did not permit alloca to be used in BFD, because on
> > systems which do not have alloca the version in libiberty would call
> > xmalloc, which might cause the program to crash when it ran out of
> > memory. I believe that BFD should never crash because it runs out of
> > memory; instead, it should return the appropriate error to the caller.
> > (That's why I wrote the objalloc interface when obstacks were changed
> > to no longer support a failure to allocate memory.) However, I do not
> > know what the current thinking is on alloca in BFD.
>
> Well, alloca() is called in BFD:
Yes, I know. Those were all added since I was the chief maintainer.
Ian
next prev parent reply other threads:[~2001-08-21 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-21 12:09 Thiemo Seufer
2001-08-21 13:20 ` Ian Lance Taylor
2001-08-21 14:46 ` Thiemo Seufer
2001-08-21 14:56 ` Ian Lance Taylor [this message]
2001-08-23 7:42 ` Nick Clifton
2001-08-23 8:48 ` Thiemo Seufer
2001-08-23 9:02 ` Jakub Jelinek
2001-08-23 9:15 ` Thiemo Seufer
2001-08-23 10:13 ` Andrew Cagney
2001-08-23 10:29 ` Ian Lance Taylor
2001-08-23 11:42 ` Andrew Cagney
2001-08-23 11:49 ` Jakub Jelinek
2001-08-23 10:16 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=si4rr113q3.fsf@daffy.airs.com \
--to=ian@zembu.com \
--cc=binutils@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).