From: Richard Sandiford <rsandifo@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org,
libstdc++@gcc.gnu.org, binutils@sources.redhat.com,
gdb-patches@sources.redhat.com
Subject: Re: Add config/gxx-include-dir.m4 (patch 3/4 for PR 7305)
Date: Fri, 03 Dec 2004 10:55:00 -0000 [thread overview]
Message-ID: <wvnoehbejnx.fsf@talisman.cambridge.redhat.com> (raw)
In-Reply-To: <oreki8k0d9.fsf@livre.redhat.lsd.ic.unicamp.br> (Alexandre Oliva's message of "02 Dec 2004 16:42:42 -0200")
Alexandre Oliva <aoliva@redhat.com> writes:
> On Nov 25, 2004, Richard Sandiford <rsandifo@redhat.com> wrote:
>
>> * configure.in: Include config/gxx-include-dir.m4. Use
>> TL_AC_GXX_INCLUDE_DIR. Remove some now-redundant AC_SUBSTs.
>> * configure: Regenerate.
>
>> config/
>> * gxx-include-dir.m4: New file.
>
> Looks good, but shouldn't gcc/ and libstdc++-v3/ use it as well?
FWIW, I touched on this in the 1/4 message, but (unhelpfully)
not in the one above the patch itself:
> This series of patches instead adds a new config/gxx-include-dir.m4
> fragment that can be shared between configure scripts. To avoid
> getting too sidetracked, the patches will only make ./configure and
> libjava/configure use this new fragment, so while there'll be no net
> increase in duplication, there'll unfortunately be no net reduction
> either.
The problem is that gcc/ wants to do something slightly different
and the libstdc++ code is bound up with other things. The changes
didn't look entirely mechanical.
> Or was this for 4/4, that I seem to not have received?
In case anyone else is wondering about that, 4/4 only affected
libjava, so I only posted it to libjava-patches. I should have
made that clearer, sorry.
> In case it wasn't clear: ok, please check it in :-)
Done, thanks.
Richard
next prev parent reply other threads:[~2004-12-03 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-25 20:47 Factor configure-time gcc version checks (patch 1/4 " Richard Sandiford
2004-11-25 20:50 ` Remove config.if (patch 2/4 " Richard Sandiford
2004-12-02 20:07 ` Alexandre Oliva
2004-11-25 20:54 ` Add config/gxx-include-dir.m4 (patch 3/4 " Richard Sandiford
2004-12-02 20:07 ` Alexandre Oliva
2004-12-03 10:55 ` Richard Sandiford [this message]
2004-11-25 21:05 ` Factor configure-time gcc version checks (patch 1/4 " Zack Weinberg
2004-11-25 21:28 ` Joseph S. Myers
2004-11-26 21:48 ` Zack Weinberg
2004-11-26 9:06 ` Richard Sandiford
2004-11-26 10:37 ` Andrew Haley
2004-12-01 23:08 ` DJ Delorie
2004-12-02 11:22 ` Richard Sandiford
2004-12-02 14:15 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wvnoehbejnx.fsf@talisman.cambridge.redhat.com \
--to=rsandifo@redhat.com \
--cc=aoliva@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=java-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).