From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14912 invoked by alias); 3 Dec 2004 10:55:16 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 14667 invoked from network); 3 Dec 2004 10:54:51 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 3 Dec 2004 10:54:51 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iB3AsjkU008234; Fri, 3 Dec 2004 05:54:50 -0500 Received: from talisman.cambridge.redhat.com (talisman.cambridge.redhat.com [172.16.18.81]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iB3Asir26885; Fri, 3 Dec 2004 05:54:44 -0500 Received: from talisman.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by talisman.cambridge.redhat.com (8.13.1/8.12.10) with ESMTP id iB3AshGE015800; Fri, 3 Dec 2004 10:54:43 GMT Received: (from rsandifo@localhost) by talisman.cambridge.redhat.com (8.13.1/8.12.10/Submit) id iB3Ashiv015799; Fri, 3 Dec 2004 10:54:43 GMT X-Authentication-Warning: talisman.cambridge.redhat.com: rsandifo set sender to rsandifo@redhat.com using -f To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: Add config/gxx-include-dir.m4 (patch 3/4 for PR 7305) References: <87is7tejx4.fsf@redhat.com> <87act5ejl0.fsf@redhat.com> From: Richard Sandiford Date: Fri, 03 Dec 2004 10:55:00 -0000 In-Reply-To: (Alexandre Oliva's message of "02 Dec 2004 16:42:42 -0200") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-12/txt/msg00027.txt.bz2 Alexandre Oliva writes: > On Nov 25, 2004, Richard Sandiford wrote: > >> * configure.in: Include config/gxx-include-dir.m4. Use >> TL_AC_GXX_INCLUDE_DIR. Remove some now-redundant AC_SUBSTs. >> * configure: Regenerate. > >> config/ >> * gxx-include-dir.m4: New file. > > Looks good, but shouldn't gcc/ and libstdc++-v3/ use it as well? FWIW, I touched on this in the 1/4 message, but (unhelpfully) not in the one above the patch itself: > This series of patches instead adds a new config/gxx-include-dir.m4 > fragment that can be shared between configure scripts. To avoid > getting too sidetracked, the patches will only make ./configure and > libjava/configure use this new fragment, so while there'll be no net > increase in duplication, there'll unfortunately be no net reduction > either. The problem is that gcc/ wants to do something slightly different and the libstdc++ code is bound up with other things. The changes didn't look entirely mechanical. > Or was this for 4/4, that I seem to not have received? In case anyone else is wondering about that, 4/4 only affected libjava, so I only posted it to libjava-patches. I should have made that clearer, sorry. > In case it wasn't clear: ok, please check it in :-) Done, thanks. Richard