public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org,
	libstdc++@gcc.gnu.org, binutils@sources.redhat.com,
	gdb-patches@sources.redhat.com
Subject: Re: Factor configure-time gcc version checks (patch 1/4 for PR 7305)
Date: Thu, 02 Dec 2004 11:22:00 -0000	[thread overview]
Message-ID: <wvnpt1tgd1v.fsf@talisman.cambridge.redhat.com> (raw)
In-Reply-To: <200412012307.iB1N7mYN011345@greed.delorie.com> (DJ Delorie's message of "Wed, 1 Dec 2004 18:07:48 -0500")

DJ Delorie <dj@redhat.com> writes:
> Sorry for missing this.  This is OK with me.  Please make sure both
> src and gcc are updated, for those files that are common (TL and
> config).

Thanks, installed to src/ and gcc/.  If you have time, could you
look at the two follow-up patches as well?

    http://gcc.gnu.org/ml/gcc-patches/2004-11/msg02186.html
    http://gcc.gnu.org/ml/gcc-patches/2004-11/msg02188.html

TIA.

> At some future time, it might be useful to handle the case where an
> in-tree gcc is not available, and it may use $(CC) somehow.

FWIW, the version check in gcc-version.m4 does have a stab,
but I don't know how effective it is:

> + if test -f "${gcc_version_trigger}"; then
> +   gcc_version_full=`grep version_string "${gcc_version_trigger}" | sed -e 's/.*"\([^"]*\)".*/\1/'`
> + else
> +   gcc_version_full=`$CC -v 2>&1 | sed -n 's/^gcc version //p'`
> + fi

(That bit was copied verbatim from config.if, which the first patch
above deletes.)

Richard

  reply	other threads:[~2004-12-02 11:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-25 20:47 Richard Sandiford
2004-11-25 20:50 ` Remove config.if (patch 2/4 " Richard Sandiford
2004-12-02 20:07   ` Alexandre Oliva
2004-11-25 20:54 ` Add config/gxx-include-dir.m4 (patch 3/4 " Richard Sandiford
2004-12-02 20:07   ` Alexandre Oliva
2004-12-03 10:55     ` Richard Sandiford
2004-11-25 21:05 ` Factor configure-time gcc version checks (patch 1/4 " Zack Weinberg
2004-11-25 21:28   ` Joseph S. Myers
2004-11-26 21:48     ` Zack Weinberg
2004-11-26  9:06   ` Richard Sandiford
2004-11-26 10:37 ` Andrew Haley
2004-12-01 23:08 ` DJ Delorie
2004-12-02 11:22   ` Richard Sandiford [this message]
2004-12-02 14:15 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wvnpt1tgd1v.fsf@talisman.cambridge.redhat.com \
    --to=rsandifo@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=dj@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=java-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).