From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30886 invoked by alias); 2 Dec 2004 11:22:45 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 30796 invoked from network); 2 Dec 2004 11:22:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 2 Dec 2004 11:22:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iB2BMYYD021301; Thu, 2 Dec 2004 06:22:34 -0500 Received: from talisman.cambridge.redhat.com (talisman.cambridge.redhat.com [172.16.18.81]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iB2BMMr24157; Thu, 2 Dec 2004 06:22:22 -0500 Received: from talisman.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by talisman.cambridge.redhat.com (8.13.1/8.12.10) with ESMTP id iB2BMLf9011630; Thu, 2 Dec 2004 11:22:21 GMT Received: (from rsandifo@localhost) by talisman.cambridge.redhat.com (8.13.1/8.12.10/Submit) id iB2BMKlf011614; Thu, 2 Dec 2004 11:22:20 GMT X-Authentication-Warning: talisman.cambridge.redhat.com: rsandifo set sender to rsandifo@redhat.com using -f To: DJ Delorie Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: Factor configure-time gcc version checks (patch 1/4 for PR 7305) References: <87is7tejx4.fsf@redhat.com> <200412012307.iB1N7mYN011345@greed.delorie.com> From: Richard Sandiford Date: Thu, 02 Dec 2004 11:22:00 -0000 In-Reply-To: <200412012307.iB1N7mYN011345@greed.delorie.com> (DJ Delorie's message of "Wed, 1 Dec 2004 18:07:48 -0500") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-12/txt/msg00016.txt.bz2 DJ Delorie writes: > Sorry for missing this. This is OK with me. Please make sure both > src and gcc are updated, for those files that are common (TL and > config). Thanks, installed to src/ and gcc/. If you have time, could you look at the two follow-up patches as well? http://gcc.gnu.org/ml/gcc-patches/2004-11/msg02186.html http://gcc.gnu.org/ml/gcc-patches/2004-11/msg02188.html TIA. > At some future time, it might be useful to handle the case where an > in-tree gcc is not available, and it may use $(CC) somehow. FWIW, the version check in gcc-version.m4 does have a stab, but I don't know how effective it is: > + if test -f "${gcc_version_trigger}"; then > + gcc_version_full=`grep version_string "${gcc_version_trigger}" | sed -e 's/.*"\([^"]*\)".*/\1/'` > + else > + gcc_version_full=`$CC -v 2>&1 | sed -n 's/^gcc version //p'` > + fi (That bit was copied verbatim from config.if, which the first patch above deletes.) Richard