From: Richard Sandiford <rsandifo@redhat.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Daniel Jacobowitz <drow@false.org>, binutils@sources.redhat.com
Subject: Re: Binutils builds broken with -Werror
Date: Mon, 21 Mar 2005 13:19:00 -0000 [thread overview]
Message-ID: <wvnu0n56z8a.fsf@talisman.cambridge.redhat.com> (raw)
In-Reply-To: <423E89B0.6000901@redhat.com> (Nick Clifton's message of "Mon, 21 Mar 2005 08:45:36 +0000")
Nick Clifton <nickc@redhat.com> writes:
> + # Disable -Werror, if it has been enabled, when building generated C
> source
> + # files since old versions of bison & yacc will produce working code which
> + # contain compile time warnings.
> + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
> + $(GENERATED_OFILES):
> + $(COMPILE) -c `basename $@ .o`.c -Wno-error
> +
I don't think you should hard-code -Wno-error like this. Isn't binutils
supposed to buildable with non-gcc compilers? (And it does build with
MIPSpro FWIW, or at least it did recently.)
Richard
next prev parent reply other threads:[~2005-03-21 11:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 2:24 Daniel Jacobowitz
2005-03-21 12:08 ` Nick Clifton
2005-03-21 13:19 ` Richard Sandiford [this message]
2005-03-22 17:08 ` Nick Clifton
2005-03-22 17:12 ` Ian Lance Taylor
2005-03-22 17:31 ` Nick Clifton
2005-03-22 18:14 ` Maciej W. Rozycki
2005-03-22 18:24 ` Paul Brook
2005-03-22 18:48 ` Paul Brook
2005-03-22 19:38 ` Ian Lance Taylor
2005-03-22 19:44 ` Ian Lance Taylor
2005-03-22 21:54 ` Maciej W. Rozycki
2005-03-22 21:56 ` Maciej W. Rozycki
2005-03-23 14:43 ` Nick Clifton
2005-03-23 15:34 ` Nick Clifton
2005-03-25 2:15 ` Maciej W. Rozycki
2005-03-22 19:27 ` Dave Korn
2005-03-22 20:49 ` Nick Clifton
2005-03-23 5:31 ` Andreas Schwab
2005-03-23 14:41 ` Nick Clifton
2005-03-24 23:48 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wvnu0n56z8a.fsf@talisman.cambridge.redhat.com \
--to=rsandifo@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=drow@false.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).