Re: TLS support for MIPS

[Richard Sandiford <rsandifo@redhat.com>]

So, I was wondering why the number of gas tests suddenly went down
to 200 ;) and found it was because of:

> Index: binutils/gas/testsuite/gas/mips/mips.exp
> ===================================================================
> --- binutils.orig/gas/testsuite/gas/mips/mips.exp	2005-02-24 13:47:29.486308610 -0500
> +++ binutils/gas/testsuite/gas/mips/mips.exp	2005-02-24 13:48:45.022872138 -0500
> @@ -336,6 +336,11 @@ proc run_list_test_arches { name opts ar
>      foreach arch $arch_list {
>  	run_list_test_arch "$name" "$opts" "$arch"
>      }
> +
> +    if $elf {
> +	run_list_test "tls-ill" "-32"
> +	run_dump_test "tls-o32"
> +    }
>  }

which led to:

---------------------------------------------------------------------------
ERROR: can't read "elf": no such variable
    while executing
"if $elf {
        run_list_test "tls-ill" "-32"
        run_dump_test "tls-o32"
    }"
    (procedure "run_list_test_arches" line 6)
    invoked from within
"run_list_test_arches "branch-misc-2" "-32 -non_shared" [mips_arch_list_matching mips1]"
[...]
---------------------------------------------------------------------------

Why did you add these tests to run_list_test_arches?  Was it just
a merge error?  I was going to install the patch below as obvious
but thought I'd better check first.

Richard


Index: gas/testsuite/gas/mips/mips.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips.exp,v
retrieving revision 1.102
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.102 mips.exp
*** gas/testsuite/gas/mips/mips.exp	2 Mar 2005 21:22:47 -0000	1.102
--- gas/testsuite/gas/mips/mips.exp	3 Mar 2005 10:24:17 -0000
*************** proc run_list_test_arches { name opts ar
*** 336,346 ****
      foreach arch $arch_list {
  	run_list_test_arch "$name" "$opts" "$arch"
      }
- 
-     if $elf {
- 	run_list_test "tls-ill" "-32"
- 	run_dump_test "tls-o32"
-     }
  }
  
  
--- 336,341 ----
*************** if { [istarget mips*-*-*] } then {
*** 690,695 ****
--- 685,693 ----
  	}
  	run_dump_test "elf-consthilo"
  	run_dump_test "expr1"
+ 
+ 	run_list_test "tls-ill" "-32"
+ 	run_dump_test "tls-o32"
      }
  
      if $has_newabi {