From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7997 invoked by alias); 3 May 2003 06:54:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 7990 invoked from network); 3 May 2003 06:54:16 -0000 Received: from unknown (HELO mms2.broadcom.com) (63.70.210.59) by sources.redhat.com with SMTP; 3 May 2003 06:54:16 -0000 Received: from 63.70.210.1 by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (MMS v5.5.2)); Fri, 02 May 2003 23:51:02 -0700 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id XAA00242 for ; Fri, 2 May 2003 23:53:50 -0700 (PDT) Received: from dt-sj3-118.sj.broadcom.com (dt-sj3-118 [10.21.64.118]) by mail-sj1-5.sj.broadcom.com (8.12.9/8.12.9/SSF) with ESMTP id h436s8ov014395 for ; Fri, 2 May 2003 23: 54:08 -0700 (PDT) Received: (from cgd@localhost) by dt-sj3-118.sj.broadcom.com ( 8.9.1/SJ8.9.1) id XAA27121; Fri, 2 May 2003 23:54:08 -0700 (PDT) To: binutils@sources.redhat.com Subject: Re: [applies mips testsuite patch] init mips arch array. References: From: cgd@broadcom.com Date: Sat, 03 May 2003 06:54:00 -0000 In-Reply-To: cgd@broadcom.com's message of "Fri, 2 May 2003 05:32:49 +0000 (UTC)" Message-ID: MIME-Version: 1.0 X-WSS-ID: 12ADB95C83891-01-01 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00062.txt.bz2 At Fri, 2 May 2003 05:32:49 +0000 (UTC), cgd@broadcom.com wrote: > Applied as obvious. Ran a test on compilers which included multilibs > ("multiple variations" if you will 8-), and happened to also check > gas... and noticed that the test ERRORed out! Made me feel lame! > > I've also applied it to the branch. This worked with the current 'src' tcl/expect, but upon further testing with a random old version that i happened to have in my path when doing a non-unified build, i found that it wasn't OK with old versions of tcl. looking at the tcl manuals, looks like 'array unset' is new. whee! the following has been verified on old and new, and applied. cgd -- [ gas/testsuite/ChangeLog ] 2003-05-02 Chris Demetriou * gas/mips/mips.exp (mips_arch_init): Reimplement in a way that's safe with ancient versions of tcl/expect. Index: gas/mips/mips.exp =================================================================== RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips.exp,v retrieving revision 1.68 diff -u -p -r1.68 mips.exp --- gas/mips/mips.exp 2 May 2003 05:29:13 -0000 1.68 +++ gas/mips/mips.exp 3 May 2003 06:49:30 -0000 @@ -84,7 +84,9 @@ # to be empty. proc mips_arch_init {} { global mips_arches - array unset mips_arches + + # Catch becuase the variable won't be set the first time through. + catch {unset mips_arches} } # mips_arch_create ARCH GPRSIZE EXTENDS PROPS AS_FLAGS OBJDUMP_FLAGS \