From mboxrd@z Thu Jan 1 00:00:00 1970 From: cgd@broadcom.com To: "Hans-Peter Nilsson" Cc: hjl@lucon.org, binutils@sources.redhat.com Subject: Re: PATCH: Add the "ld -r" test for ELF visibility. Date: Wed, 31 Oct 2001 13:35:00 -0000 Message-id: References: X-SW-Source: 2001-10/msg00642.html "Hans-Peter Nilsson" writes: > > + .: [0-9a-fA-F]* 0 NOTYPE GLOBAL PROTECTED . protected > > +#... > > Not sure why I think so, but I think the last "#..." should > better be "#pass". Perhaps it's because things then look a bit > clearer when the test fails. Actually, currently, AFAIK, a trailing #... at end of file _doesn't_ match additional output in the objdump dump output. (I posted a patch to make it so, it was quasi-approved, but I didn't get around to applying it... and now that i know about #pass I don't know that it's really a good idea.) Also, e.g. for: .: [0-9a-fA-F]* 0 NOTYPE GLOBAL HIDDEN . hidden I think i'd suggest: +[0-9]+: [0-9a-fA-F]+ 0 NOTYPE GLOBAL HIDDEN +[0-9]+ hidden (more tolerant of different section numbers) chris