From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 262EC385782C for ; Mon, 27 Jun 2022 22:43:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 262EC385782C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id BDBC930005B6; Tue, 28 Jun 2022 00:43:10 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 71A6E2E83468; Tue, 28 Jun 2022 00:43:10 +0200 (CEST) From: Mark Wielaard To: buildbot@sourceware.org Cc: Tom de Vries , Mark Wielaard Subject: [COMMITTED] Fix binutils-gdb configure --enable-targets=all Date: Tue, 28 Jun 2022 00:42:48 +0200 Message-Id: <20220627224248.39699-1-mark@klomp.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2022 22:43:13 -0000 There was a type in the configure of both binutils and gdb. It is --enable-targets=all, not --enable-target=all (missing s). Only use this on fast builders, tumbleweed x86_64 for binutils, fedora x86_64. --- builder/master.cfg | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/builder/master.cfg b/builder/master.cfg index 644af50..fa53ecb 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -1495,7 +1495,7 @@ binutils_step_configure_target_all = steps.Configure( command=['../binutils-gdb/configure', '--enable-gold', '--enable-shared', - '--enable-target=all'], + '--enable-targets=all'], name='configure', haltOnFailure=True) binutils_step_compile = steps.Compile( @@ -1546,7 +1546,7 @@ binutils_debian_amd64_builder = util.BuilderConfig( readContainerFile('debian-stable')}, workernames=vm_workers, tags=["binutils", "debian", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_debian_amd64_builder) binutils_try_debian_amd64_builder = util.BuilderConfig( @@ -1556,7 +1556,7 @@ binutils_try_debian_amd64_builder = util.BuilderConfig( readContainerFile('debian-stable')}, workernames=vm_workers, tags=["binutils-try", "debian", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_try_debian_amd64_builder) binutils_fedora_x86_64_builder = util.BuilderConfig( @@ -1565,7 +1565,7 @@ binutils_fedora_x86_64_builder = util.BuilderConfig( readContainerFile('fedora-latest')}, workernames=vm_workers, tags=["binutils", "fedora", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_fedora_x86_64_builder) binutils_try_fedora_x86_64_builder = util.BuilderConfig( @@ -1575,7 +1575,7 @@ binutils_try_fedora_x86_64_builder = util.BuilderConfig( readContainerFile('fedora-latest')}, workernames=vm_workers, tags=["binutils-try", "fedora", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_try_fedora_x86_64_builder) binutils_fedora_s390x_builder = util.BuilderConfig( @@ -1668,7 +1668,7 @@ binutils_opensuseleap_x86_64_builder = util.BuilderConfig( readContainerFile('opensuse-leap')}, workernames=vm_workers, tags=["binutils", "opensuseleap", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_opensuseleap_x86_64_builder) binutils_try_opensuseleap_x86_64_builder = util.BuilderConfig( @@ -1678,7 +1678,7 @@ binutils_try_opensuseleap_x86_64_builder = util.BuilderConfig( readContainerFile('opensuse-leap')}, workernames=vm_workers, tags=["binutils-try", "opensuseleap", "x86_64"], - factory=binutils_factory_target_all) + factory=binutils_factory) c['builders'].append(binutils_try_opensuseleap_x86_64_builder) # gdb build steps, factory and builders @@ -1696,9 +1696,14 @@ gdb_rm_step = steps.ShellCommand( name="rm -rf gdb-build", haltOnFailure=True) gdb_configure_step = steps.Configure( + workdir='gdb-build', + command=['../binutils-gdb/configure'], + name='configure', + haltOnFailure=True) +gdb_configure_targets_all_step = steps.Configure( workdir='gdb-build', command=['../binutils-gdb/configure', - '--enable-target=all'], + '--enable-targets=all'], name='configure', haltOnFailure=True) gdb_make_step = steps.Compile( @@ -1782,6 +1787,24 @@ gdb_factory.addSteps(bunsen_logfile_upload_steps([ (["../gdb-build/gdb/testsuite/gdb.sum", "../gdb-build/gdb/testsuite/gdb.log", "../gdb-build/gdb/config.log"],"gdb")], tagsuffix="/extended-gdbserver")) +gdb_targets_all_factory = util.BuildFactory() +gdb_targets_all_factory.addStep(gdb_git_step) +gdb_targets_all_factory.addStep(gdb_rm_step) +gdb_targets_all_factory.addStep(gdb_configure_targets_all_step) +gdb_targets_all_factory.addStep(gdb_make_step) +gdb_targets_all_factory.addStep(gdb_check_step) +gdb_targets_all_factory.addSteps(bunsen_logfile_upload_steps([ # only a few tests being run but still + (["../gdb-build/gdb/testsuite/gdb.sum", "../gdb-build/gdb/testsuite/gdb.log", "../gdb-build/gdb/config.log"],"gdb")], + tagsuffix="/native")) +gdb_targets_all_factory.addStep(gdb_check_native_gdbserver_step) +gdb_targets_all_factory.addSteps(bunsen_logfile_upload_steps([ + (["../gdb-build/gdb/testsuite/gdb.sum", "../gdb-build/gdb/testsuite/gdb.log", "../gdb-build/gdb/config.log"],"gdb")], + tagsuffix="/gdbserver")) +gdb_targets_all_factory.addStep(gdb_check_native_extended_gdbserver_step) +gdb_targets_all_factory.addSteps(bunsen_logfile_upload_steps([ + (["../gdb-build/gdb/testsuite/gdb.sum", "../gdb-build/gdb/testsuite/gdb.log", "../gdb-build/gdb/config.log"],"gdb")], + tagsuffix="/extended-gdbserver")) + # Used for armhf only because of # https://sourceware.org/bugzilla/show_bug.cgi?id=28561 gdb_factory_make_only = util.BuildFactory() @@ -1814,7 +1837,7 @@ gdb_fedora_x86_64_builder = util.BuilderConfig( readContainerFile('fedora-latest')}, workernames=vm_workers, tags=["gdb", "fedora", "x86_64"], - factory=gdb_factory) + factory=gdb_targets_all_factory) c['builders'].append(gdb_fedora_x86_64_builder) gdb_try_fedora_x86_64_builder = util.BuilderConfig( -- 2.30.2